lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix regression for creating repositories in root-based containers #172

Merged
justusbunsi merged 1 commits from refs/pull/172/head into master 2021-06-09 14:35:51 +00:00
Conversation 9 Commits 1 Files Changed 1 +1 -1
justusbunsi commented 2021-06-09 06:17:45 +00:00 (Migrated from gitea.com)
Copy Link

Due to #160 it was no longer possible to create repositories in root-based containers. This was caused by the missing /tmp/gitea directory in that image. It was dynamically created by Gitea internal functionality with less privileges than necessary.

Explicitly creating the directory and set proper permissions fix this.

Fixes: #171

Due to #160 it was no longer possible to create repositories in root-based containers. This was caused by the missing `/tmp/gitea` directory in that image. It was dynamically created by Gitea internal functionality with less privileges than necessary. Explicitly creating the directory and set proper permissions fix this. Fixes: #171
justusbunsi commented 2021-06-09 06:19:13 +00:00 (Migrated from gitea.com)
Copy Link

@luhahn Does the increase of Chart.yaml app version does the trick to indicate the correct version for the chart? As mentioned in issue #171, this was incorrect due to the previous PR #160.

@luhahn Does the increase of Chart.yaml app version does the trick to indicate the correct version for the chart? As mentioned in issue #171, this was incorrect due to the previous PR #160.
luhahn commented 2021-06-09 07:23:22 +00:00 (Migrated from gitea.com)
Copy Link

@luhahn Does the increase of Chart.yaml app version does the trick to indicate the correct version for the chart? As mentioned in issue #171, this was incorrect due to the previous PR #160.

Yes, missed it in your PR, sorry :D.

> @luhahn Does the increase of Chart.yaml app version does the trick to indicate the correct version for the chart? As mentioned in issue #171, this was incorrect due to the previous PR #160. Yes, missed it in your PR, sorry :D.
luhahn (Migrated from gitea.com) reviewed 2021-06-09 07:34:46 +00:00
luhahn commented 2021-06-09 07:39:57 +00:00 (Migrated from gitea.com)
Copy Link

Please also add the image version into the readmes value description

Please also add the image version into the readmes value description
justusbunsi commented 2021-06-09 10:14:34 +00:00 (Migrated from gitea.com)
Copy Link

Please also add the image version into the readmes value description

Seems to be already done in 031b58c90e.

> Please also add the image version into the readmes value description Seems to be already done in 031b58c90ea3b18eb8964fab5b1f214e78fca79b.
luhahn commented 2021-06-09 11:47:11 +00:00 (Migrated from gitea.com)
Copy Link

Please also add the image version into the readmes value description

Seems to be already done in 031b58c90e.

right, missed that one, sorry

> > Please also add the image version into the readmes value description > > Seems to be already done in 031b58c90ea3b18eb8964fab5b1f214e78fca79b. right, missed that one, sorry
luhahn (Migrated from gitea.com) approved these changes 2021-06-09 11:53:06 +00:00
justusbunsi commented 2021-06-09 12:18:19 +00:00 (Migrated from gitea.com)
Copy Link

Branch up-to-date. Hopefully these changes do not introduce other side-effects. ?

Branch up-to-date. Hopefully these changes do not introduce other side-effects. ?
6543 (Migrated from gitea.com) approved these changes 2021-06-09 13:39:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
6543
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#172
No description provided.
Delete Branch "refs/pull/172/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?