lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Fix regression for unspecified DOMAIN and ROOT_URL #185

Merged
justusbunsi merged 2 commits from refs/pull/185/head into master 2021-06-29 19:24:45 +00:00
Conversation 2 Commits 2 Files Changed 1 +2 -2
justusbunsi commented 2021-06-25 12:08:38 +00:00 (Migrated from gitea.com)
Copy Link

In case a user did not specify DOMAIN in .Values.gitea.config.server,
the chart generated incorrect value for that app.ini setting so that
Gitea crashed on startup.

Same for ROOT_URL.

In case a user did not specify DOMAIN in .Values.gitea.config.server, the chart generated incorrect value for that app.ini setting so that Gitea crashed on startup. Same for ROOT_URL.
luhahn (Migrated from gitea.com) approved these changes 2021-06-28 07:22:57 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

tested -> looks good :)

tested -> looks good :)
techknowlogick (Migrated from gitea.com) approved these changes 2021-06-29 19:24:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/bug
Milestone
No items
No Milestone Release 4.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#185
No description provided.
Delete Branch "refs/pull/185/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?