lunny/helm-chart
1
0
Fork 1
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

Remove builtIn dependency values #268

Merged
luhahn merged 1 commits from refs/pull/268/head into master 2021-12-22 15:41:36 +00:00
Conversation 7 Commits 1 Files Changed 1 +34 -12
luhahn commented 2021-12-21 11:24:56 +00:00 (Migrated from gitea.com)
Copy Link

⚠️ Breaking

Moved the values to enable the dependencies into the dependencies itself, this way we don't need a seperate field in the values and it is more obvious how to enable for example postgresql.

⚠️ Breaking Moved the values to enable the dependencies into the dependencies itself, this way we don't need a seperate field in the values and it is more obvious how to enable for example postgresql.
justusbunsi (Migrated from gitea.com) reviewed 2021-12-21 12:06:05 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

README needs to be modified. The other parts LGTM.

README needs to be modified. The other parts LGTM.
justusbunsi (Migrated from gitea.com) reviewed 2021-12-21 12:23:01 +00:00
justusbunsi (Migrated from gitea.com) reviewed 2021-12-21 13:15:08 +00:00
justusbunsi (Migrated from gitea.com) approved these changes 2021-12-21 13:26:40 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

If I didn't miss anything, LGTM now.

If I didn't miss anything, LGTM now.
justusbunsi commented 2021-12-22 12:30:08 +00:00 (Migrated from gitea.com)
Copy Link

My approval is still valid after reviewing the latest changes. ?

My approval is still valid after reviewing the latest changes. ?
wxiaoguang (Migrated from gitea.com) reviewed 2021-12-22 13:20:17 +00:00
zeripath (Migrated from gitea.com) approved these changes 2021-12-22 14:39:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
zeripath
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/breaking
Milestone
No items
No Milestone 5.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
lunny
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#268
No description provided.
Delete Branch "refs/pull/268/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?