lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

add global values support #322

Merged
cnfatal merged 1 commits from master into master 2022-06-09 10:55:09 +00:00
Conversation 1 Commits 1 Files Changed 3 +41 -8
cnfatal commented 2022-05-23 03:11:43 +00:00 (Migrated from gitea.com)
Copy Link

add global values support for .global.storageClass .global.imageRegistry and .global.imagePullSecrets

add global values support for `.global.storageClass` `.global.imageRegistry` and `.global.imagePullSecrets`
👍 1
justusbunsi commented 2022-05-23 05:01:04 +00:00 (Migrated from gitea.com)
Copy Link

+1 for switching to readme-generator. Thanks for the effort. Would you mind splitting the two parts into different PRs? That would make a review much easier.

EDIT: Splitted into different PRs.

~~+1 for switching to readme-generator. Thanks for the effort. Would you mind splitting the two parts into different PRs? That would make a review much easier.~~ EDIT: Splitted into different PRs.
justusbunsi (Migrated from gitea.com) reviewed 2022-05-27 10:41:14 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

Many thanks for your contribution. I've marked some minor things.

Many thanks for your contribution. I've marked some minor things.
justusbunsi (Migrated from gitea.com) reviewed 2022-06-06 16:56:07 +00:00
luhahn (Migrated from gitea.com) approved these changes 2022-06-09 10:52:00 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
justusbunsi (Migrated from gitea.com) approved these changes 2022-06-09 10:54:16 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#322
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?