lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

generate readme Parameters from values.yaml #323

Merged
cnfatal merged 1 commits from refs/pull/323/head into master 2022-06-09 11:21:26 +00:00
Conversation 5 Commits 1 Files Changed 4 +378 -195
cnfatal commented 2022-05-23 10:54:39 +00:00 (Migrated from gitea.com)
Copy Link
No description provided.
justusbunsi (Migrated from gitea.com) reviewed 2022-05-27 11:27:21 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

Appreciate your already invested time.

Appreciate your already invested time.
justusbunsi (Migrated from gitea.com) reviewed 2022-05-27 17:18:50 +00:00
justusbunsi (Migrated from gitea.com) reviewed 2022-05-27 17:23:54 +00:00
justusbunsi (Migrated from gitea.com) reviewed 2022-06-06 17:14:49 +00:00
justusbunsi commented 2022-06-09 03:43:51 +00:00 (Migrated from gitea.com)
Copy Link

@cnfatal Not sure if you've seen this comment. It might be easy to overlook as it is within an outdated review part. Anything else LGTM now.
https://gitea.com/gitea/helm-chart/pulls/323#issuecomment-700828 (comment)

@cnfatal Not sure if you've seen this comment. It might be easy to overlook as it is within an outdated review part. Anything else LGTM now. https://gitea.com/gitea/helm-chart/pulls/323#issuecomment-700828 (comment)
cnfatal commented 2022-06-09 03:48:46 +00:00 (Migrated from gitea.com)
Copy Link

@cnfatal Not sure if you seen this comment. It might be easy to overlook as it is within an outdated review part. Anything else LGTM now.
https://gitea.com/gitea/helm-chart/pulls/323#issuecomment-700828

my fault, i overlooked it.

> @cnfatal Not sure if you seen this comment. It might be easy to overlook as it is within an outdated review part. Anything else LGTM now. > https://gitea.com/gitea/helm-chart/pulls/323#issuecomment-700828 my fault, i overlooked it.
justusbunsi commented 2022-06-09 03:53:12 +00:00 (Migrated from gitea.com)
Copy Link

Do you mind regenerating the readme one last time to match the current values.yaml state?

Do you mind regenerating the readme one last time to match the current values.yaml state?
cnfatal commented 2022-06-09 05:22:30 +00:00 (Migrated from gitea.com)
Copy Link

Do you mind regenerating the readme one last time to match the current values.yaml state?

I also squashed the two commits by the way

> Do you mind regenerating the readme one last time to match the current values.yaml state? I also squashed the two commits by the way
luhahn (Migrated from gitea.com) approved these changes 2022-06-09 10:50:21 +00:00
luhahn (Migrated from gitea.com) left a comment
Copy Link

LGTM. Thanks for your PR :)

LGTM. Thanks for your PR :)
justusbunsi (Migrated from gitea.com) approved these changes 2022-06-09 10:56:52 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

@cnfatal Please resolve the conflict so we can merge it.

@cnfatal Please resolve the conflict so we can merge it.
cnfatal commented 2022-06-09 10:57:23 +00:00 (Migrated from gitea.com)
Copy Link

I'll resolve the confilct as soon as posible

I'll resolve the confilct as soon as posible
justusbunsi (Migrated from gitea.com) reviewed 2022-06-09 11:00:00 +00:00
justusbunsi (Migrated from gitea.com) approved these changes 2022-06-09 11:20:19 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

Awesome. Thanks for taking the initiative to make all these manual changes. ?

Awesome. Thanks for taking the initiative to make all these manual changes. ?
Sign in to join this conversation.
Reviewers
No Reviewers
luhahn
justusbunsi
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/breaking
kind/docs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#323
No description provided.
Delete Branch "refs/pull/323/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?