add dnsConfig value support #329

2022-06-22T21:42:37Z

dek commented

2022-06-22 21:42:37 +00:00

(Migrated from gitea.com)

Description of the change

Add support for a new value: dnsConfig, to be passed to the statefulset pod template configuration.

Default is {}, and does not change anything from current default pod configuration.

Benefits

Ability to fix some issues encountered with Alpine-based docker images, which may break DNS resolving on some clusters.

In particular, this allows to lower the ndots value, which fixes DNS resolving of FQDNs.

dnsConfig:
  options:
    - name: ndots
      value: "1"

Also, with this setting, one can set other parameters to finely tune DNS configuration for Gitea pods, if needed:

https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config

Possible drawbacks

None.

Additional information

Some relevant links about the issue this setting allows to fix:

https://stackoverflow.com/questions/65181012/does-alpine-have-known-dns-issue-within-kubernetes

https://gitlab.alpinelinux.org/alpine/aports/-/issues/9017

Checklist

Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm

### Description of the change Add support for a new value: `dnsConfig`, to be passed to the statefulset pod template configuration. Default is `{}`, and does not change anything from current default pod configuration. ### Benefits Ability to fix some issues encountered with Alpine-based docker images, which may break DNS resolving on some clusters. In particular, this allows to lower the `ndots` value, which fixes DNS resolving of FQDNs. ``` dnsConfig: options: - name: ndots value: "1" ``` Also, with this setting, one can set other parameters to finely tune DNS configuration for Gitea pods, if needed: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config ### Possible drawbacks None. ### Additional information Some relevant links about the issue this setting allows to fix: https://stackoverflow.com/questions/65181012/does-alpine-have-known-dns-issue-within-kubernetes https://gitlab.alpinelinux.org/alpine/aports/-/issues/9017 ### Checklist  - [x] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm)

👍 2

justusbunsi (Migrated from gitea.com) approved these changes 2022-06-25 17:15:17 +00:00

justusbunsi (Migrated from gitea.com) left a comment

LGTM. Thanks for your contribution.

justusbunsi (Migrated from gitea.com) reviewed 2022-06-25 18:06:48 +00:00

dek commented

2022-06-25 18:07:46 +00:00

(Migrated from gitea.com)

Thanks !?

(Ignore for the re-review request, I misclicked)

Thanks !? (Ignore for the re-review request, I misclicked)

👍 1

justusbunsi (Migrated from gitea.com) approved these changes 2022-06-26 11:41:07 +00:00

justusbunsi (Migrated from gitea.com) left a comment

Still awesome. :)

luhahn (Migrated from gitea.com) approved these changes 2022-06-27 06:29:46 +00:00

luhahn commented

2022-06-27 06:36:14 +00:00

(Migrated from gitea.com)

merged, thank you for your contribution :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#329