Split "extraVolumeMounts" into init and container mounts #337

2022-07-10T15:15:21Z

justusbunsi commented

2022-07-10 15:15:21 +00:00

(Migrated from gitea.com)

Description of the change

This introduces two new settings extraInitVolumeMounts (1) and extraContainerVolumeMounts (2). They deprecate the extraVolumeMounts setting which is mounted into every container regardless of its use.
The first new setting (1) will only be mounted into the init containers and is useful for additional preconfiguration files. The second one (2) will only be mounted into the actual runtime container of Gitea. That way users can override specific parts of the filesystem with customization templates or files in general.

Benefits

Mount points only effective during Gitea runtime, such as custom css or additional themes don't have to be mounted into the initialization phase anymore and therefore can't interfere with those scripts.

Possible drawbacks

If a mount point shall be provided to both container types (init and runtime container), it now requires duplicated mount point specification.

Applicable issues

fixes #296

Additional information

Although this is not a breaking change, it's still mentioned as major change.
The default values for extraVolumes and extraVolumeMounts are change to empty arrays instead of null for consistency and easier handling.

Checklist

Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm

### Description of the change This introduces two new settings `extraInitVolumeMounts` (1) and `extraContainerVolumeMounts` (2). They deprecate the `extraVolumeMounts` setting which is mounted into every container regardless of its use. The first new setting (1) will only be mounted into the init containers and is useful for additional preconfiguration files. The second one (2) will only be mounted into the actual runtime container of Gitea. That way users can override specific parts of the filesystem with customization templates or files in general. ### Benefits Mount points only effective during Gitea runtime, such as custom css or additional themes don't have to be mounted into the initialization phase anymore and therefore can't interfere with those scripts. ### Possible drawbacks If a mount point shall be provided to both container types (init and runtime container), it now requires duplicated mount point specification. ### Applicable issues - fixes #296 ### Additional information Although this is not a breaking change, it's still mentioned as major change. The default values for `extraVolumes` and `extraVolumeMounts` are change to empty arrays instead of _null_ for consistency and easier handling. ### Checklist - [x] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm)

luhahn (Migrated from gitea.com) approved these changes 2022-07-26 07:09:54 +00:00

luhahn (Migrated from gitea.com) left a comment

LGTM

lafriks (Migrated from gitea.com) approved these changes 2022-08-07 19:32:09 +00:00

pat-s commented

2022-08-08 13:48:45 +00:00

(Migrated from gitea.com)

@justusbunsi Thanks for the fix! Sorry that I had no time for testing but I believe that it will work :) It's an edge case anyhow and probably won't apply to too many people - but especially because of this, thanks for putting the time in!

❤️ 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#337