lunny/helm-chart
1
0
Fork 0
Code Issues 36 Pull Requests 14 Actions Packages Projects Releases 93 Wiki Activity

add resources to init-containers #362

Closed
emiliebiscuits wants to merge 6 commits from main into main
pull from: main
merge into: lunny:main
Conversation 5 Commits 6 Files Changed 3 +21 -3
emiliebiscuits commented 2022-09-16 12:00:40 +00:00 (Migrated from gitea.com)
Copy Link

Description of the change

Added resource limits and requests to init containers.

Benefits

With resources limits and requests set, init containers can not run out of resources.
Sanitizers ( example Popeye ) will no longer complain about resources requests/limits.

Possible drawbacks

This PR allows only the same requests and limits for all init containers. Each init container cannot has its own limits and requests set separately.

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change Added resource limits and requests to init containers. ### Benefits With resources limits and requests set, init containers can not run out of resources. Sanitizers ( example Popeye ) will no longer complain about resources requests/limits. ### Possible drawbacks This PR allows only the same requests and limits for all init containers. Each init container cannot has its own limits and requests set separately. ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md`
justusbunsi commented 2022-09-22 10:56:42 +00:00 (Migrated from gitea.com)
Copy Link

In general lgtm. Please provide a pull request description according to the pull request template.

In general lgtm. Please provide a pull request description according to the pull request template.
emiliebiscuits commented 2022-09-22 12:19:08 +00:00 (Migrated from gitea.com)
Copy Link

In general lgtm. Please provide a pull request description according to the pull request template.

done

> In general lgtm. Please provide a pull request description according to the pull request template. done
justusbunsi (Migrated from gitea.com) approved these changes 2022-09-25 11:16:50 +00:00
justusbunsi (Migrated from gitea.com) left a comment
Copy Link

LGTM

LGTM
pat-s commented 2023-03-09 09:07:44 +00:00 (Migrated from gitea.com)
Copy Link

@emiliebiscuits Could you resolve the conflicts? After that, I think we can merge. Thanks again for your contribution!

@emiliebiscuits Could you resolve the conflicts? After that, I think we can merge. Thanks again for your contribution!
techknowlogick (Migrated from gitea.com) approved these changes 2023-03-10 03:07:00 +00:00
techknowlogick commented 2023-03-10 03:07:33 +00:00 (Migrated from gitea.com)
Copy Link

LGTM, could be merged when conflicts are resolved.

LGTM, could be merged when conflicts are resolved.
pat-s commented 2023-03-28 21:50:03 +00:00 (Migrated from gitea.com)
Copy Link

superseded by #423 as OP seems inactive and we can't update the branch.

superseded by #423 as OP seems inactive and we can't update the branch.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
justusbunsi
techknowlogick
Labels
Clear labels
has/backport
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/other
No Label
kind/feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lunny/helm-chart#362
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?