Add support for ServiceAccount configuration #451

2023-05-30T20:35:40Z

justusbunsi commented

2023-05-30 20:35:40 +00:00

(Migrated from gitea.com)

Description of the change

This adds a new values object serviceAccount, that allows creating a dedicated ServiceAccount with the Helm Release into the cluster. It supports all common options like labels, annotations, name override (or referring to an externally created ServiceAccount), auto-mount token, image pull secrets.

It supersedes the stale PR #357.

Benefits

Users can deploy Gitea with more fine-tuned security settings.

Applicable issues

related to #448

Additional information

I've bumped the helm-unittest plugin in the CI build, to be able to use the exists and notExists feature in the new tests.

Checklist

Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm

### Description of the change This adds a new values object `serviceAccount`, that allows creating a dedicated ServiceAccount with the Helm Release into the cluster. It supports all common options like labels, annotations, name override (or referring to an externally created ServiceAccount), auto-mount token, image pull secrets. It supersedes the stale PR #357. ### Benefits Users can deploy Gitea with more fine-tuned security settings. ### Applicable issues - related to #448 ### Additional information I've bumped the helm-unittest plugin in the CI build, to be able to use the `exists` and `notExists` feature in the new tests. ### Checklist - [x] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm)

pat-s (Migrated from gitea.com) approved these changes 2023-05-31 08:47:34 +00:00

pat-s (Migrated from gitea.com) left a comment

Great! And so many tests...awesome ;)

LGTM

Great! And so many tests...awesome ;) LGTM

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#451