WIP: initial working version of runners-only deployment #727

2024-11-16T04:38:37Z

vjm commented

2024-11-16 04:38:37 +00:00

(Migrated from gitea.com)

Description of the change

add the ability to deploy runners only. This is helpful when you want self-hosted runners for an instance. My current use case is for multi-platform builds, across two separate kubernetes clusters with different architecture nodes to build on.

Benefits

Ability to do native multiplatform actions builds

Possible drawbacks

None known

Applicable issues

gitea/act_runner#267

Additional information

WIP, need to add tests

Checklist

add functionality
Add documentation
Add tests

### Description of the change add the ability to deploy runners only. This is helpful when you want self-hosted runners for an instance. My current use case is for multi-platform builds, across two separate kubernetes clusters with different architecture nodes to build on. ### Benefits Ability to do native multiplatform actions builds ### Possible drawbacks None known ### Applicable issues gitea/act_runner#267 ### Additional information WIP, need to add tests ### Checklist - [X] add functionality - [ ] Add documentation - [ ] Add tests

justusbunsi (Migrated from gitea.com) reviewed 2024-11-16 04:38:38 +00:00

pat-s (Migrated from gitea.com) reviewed 2024-11-16 04:38:38 +00:00

justusbunsi commented

2024-11-27 21:21:17 +00:00

(Migrated from gitea.com)

TBH, I don't see this being part of the current Helm Chart. I understand your use case, though. With such a use case in mind and looking at the current values structure, a better solution might be having 2 separate charts for Gitea and the runner and a third "gitea-stack" combining both via subcharts. Then you could use both charts independently, or combined. Your suggested changes aim for such Gitea-stack chart.

Theoretically, if we would transform this chart into a Gitea-stack chart, there should be a severe restructurings for better grouping (such as moving current subcharts into the Gitea context for easier disabling all-at-once).

In general, I personally am open for such a restructuring at a later point (without knowing the opinion of @pat-s). "At a later point", because right now the main focus should be on solving the app.ini default restoration issue and reoccurring initContainer issues (by switching to Helm hook jobs). Both topics are long-existing issues and fixing them will introduce breaking changes on their own but make the chart more robust. If done right, we could already pave the way for such stack-like chart. The current structure would be too fragmented and maybe even fragile, IMO.

TBH, I don't see this being part of the current Helm Chart. I understand your use case, though. With such a use case in mind and looking at the current values structure, a better solution might be having 2 separate charts for Gitea and the runner and a third "gitea-stack" combining both via subcharts. Then you could use both charts independently, or combined. Your suggested changes aim for such Gitea-stack chart. Theoretically, if we would transform this chart into a Gitea-stack chart, there should be a severe restructurings for better grouping (such as moving current subcharts into the Gitea context for easier disabling all-at-once). In general, I personally am open for such a restructuring at a later point (without knowing the opinion of @pat-s). "At a later point", because right now the main focus should be on solving the app.ini default restoration issue and reoccurring initContainer issues (by switching to Helm hook jobs). Both topics are long-existing issues and fixing them will introduce breaking changes on their own but make the chart more robust. If done right, we could already pave the way for such stack-like chart. The current structure would be too fragmented and maybe even fragile, IMO.

This pull request has changes conflicting with the target branch.

README.md
templates/gitea/servicemonitor.yaml

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin vjm/runners-only-deployment:vjm/runners-only-deployment

git checkout vjm/runners-only-deployment

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lunny/helm-chart#727