19e9b07e6e
This reverts d5ce1a47eaad935ea709b7a03bfdf6c69bac8f32 and therefore adds the GPG feature back into main. As it is a breaking change, this PR now also contains the required upgrade notes. Closes #107 again. Co-authored-by: justusbunsi <sk.bunsenbrenner@gmail.com> Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/374 Reviewed-by: pat-s <pat-s@noreply.gitea.io> Reviewed-by: John Olheiser <john+gitea@jolheiser.com>
2.4 KiB
2.4 KiB
Contribution Guidelines
Any type of contribution is welcome; from new features, bug fixes, tests, refactorings for easier maintainability or documentation improvements.
Development environment
When using Visual Studio Code as IDE, following plugins might be useful:
Documentation Requirements
The README.md
must include all configuration options. The parameters section
is generated by extracting the parameter annotations from the values.yaml
file,
by using this tool.
If changes were made on configuration options, run make readme
to update the
README file.
Pull Request Requirements
When submitting or updating a PR:
- make sure it passes CI builds.
- do not make independent changes in one PR.
- try to avoid rebases. They make code reviews for large PRs and comments much harder.
- if applicable, use the PR template for a well-defined PR description.
- clearly mark breaking changes.
Local development & testing
For local development and testing of pull requests, the following workflow can be used:
- Install
minikube
andhelm
. - Start a
minikube
cluster viaminikube start
. - From the
gitea/helm-chart
directory execute the following command. This will install the dependencies listed inChart.yml
and deploy the current state of the helm chart found locally. If you want to test a branch, make sure to switch to the respective branch first.helm install --dependency-update gitea . -f values.yaml
. - Gitea is now deployed in
minikube
. To access it, it's port needs to be forwarded first fromminikube
to localhost first viakubectl --namespace default port-forward svc/gitea-http 3000:3000
. Now Gitea is accessible at http://localhost:3000.
Unit tests
# install the unittest plugin
$ helm plugin install https://github.com/heyhabito/helm-unittest
# run the unittests
make unittests