qmk_firmware/pr_checklist.html

47 lines
122 KiB
HTML
Raw Normal View History

<!DOCTYPE html>
<html lang="en-US" dir="ltr">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width,initial-scale=1">
<title>PR checklists | QMK Firmware</title>
<meta name="description" content="Documentation for QMK Firmware">
<meta name="generator" content="VitePress v1.1.3">
<link rel="preload stylesheet" href="/assets/style.No8zk9aC.css" as="style">
<script type="module" src="/assets/app.DyBQnxno.js"></script>
<link rel="preload" href="/assets/inter-roman-latin.Di8DUHzh.woff2" as="font" type="font/woff2" crossorigin="">
<link rel="modulepreload" href="/assets/chunks/theme.CuUwN9QV.js">
<link rel="modulepreload" href="/assets/chunks/framework.B9AX-CPi.js">
<link rel="modulepreload" href="/assets/pr_checklist.md.Bgi0agQn.lean.js">
<script id="check-dark-mode">(()=>{const e=localStorage.getItem("vitepress-theme-appearance")||"auto",a=window.matchMedia("(prefers-color-scheme: dark)").matches;(!e||e==="auto"?a:e==="dark")&&document.documentElement.classList.add("dark")})();</script>
<script id="check-mac-os">document.documentElement.classList.toggle("mac",/Mac|iPhone|iPod|iPad/i.test(navigator.platform));</script>
</head>
<body>
<div id="app"><div class="Layout" data-v-5d98c3a5><!--[--><!--]--><!--[--><span tabindex="-1" data-v-0f60ec36></span><a href="#VPContent" class="VPSkipLink visually-hidden" data-v-0f60ec36> Skip to content </a><!--]--><!----><header class="VPNav" data-v-5d98c3a5 data-v-ae24b3ad><div class="VPNavBar has-sidebar top" data-v-ae24b3ad data-v-ccf7ddec><div class="wrapper" data-v-ccf7ddec><div class="container" data-v-ccf7ddec><div class="title" data-v-ccf7ddec><div class="VPNavBarTitle has-sidebar" data-v-ccf7ddec data-v-ab179fa1><a class="title" href="/" data-v-ab179fa1><!--[--><!--]--><!--[--><!--[--><!--[--><img class="VPImage dark logo" src="/qmk-logo-dark.svg" alt data-v-8426fc1a><!--]--><!--[--><img class="VPImage light logo" src="/qmk-logo-light.svg" alt data-v-8426fc1a><!--]--><!--]--><!--]--><span data-v-ab179fa1>QMK Firmware</span><!--[--><!--]--></a></div></div><div class="content" data-v-ccf7ddec><div class="content-body" data-v-ccf7ddec><!--[--><!--]--><div class="VPNavBarSearch search" data-v-ccf7ddec><!--[--><!----><div id="local-search"><button type="button" class="DocSearch DocSearch-Button" aria-label="Search"><span class="DocSearch-Button-Container"><span class="vp-icon DocSearch-Search-Icon"></span><span class="DocSearch-Button-Placeholder">Search</span></span><span class="DocSearch-Button-Keys"><kbd class="DocSearch-Button-Key"></kbd><kbd class="DocSearch-Button-Key">K</kbd></span></button></div><!--]--></div><nav aria-labelledby="main-nav-aria-label" class="VPNavBarMenu menu" data-v-ccf7ddec data-v-7f418b0f><span id="main-nav-aria-label" class="visually-hidden" data-v-7f418b0f>Main Navigation</span><!--[--><!--[--><a class="VPLink link VPNavBarMenuLink" href="/" tabindex="0" data-v-7f418b0f data-v-9c663999><!--[--><span data-v-9c663999>Home</span><!--]--></a><!--]--><!--]--></nav><!----><div class="VPNavBarAppearance appearance" data-v-ccf7ddec data-v-e6aabb21><button class="VPSwitch VPSwitchAppearance" type="button" role="switch" title="Switch to dark theme" aria-checked="false" data-v-e6aabb21 data-v-d1f28634 data-v-1d5665e3><span class="check" data-v-1d5665e3><span class="icon" data-v-1d5665e3><!--[--><span class="vpi-sun sun" data-v-d1f28634></span><span class="vpi-moon moon" data-v-d1f28634></span><!--]--></span></span></button></div><div class="VPSocialLinks VPNavBarSocialLinks social-links" data-v-ccf7ddec data-v-0394ad82 data-v-7bc22406><!--[--><a class="VPSocialLink no-icon" href="https://reddit.com/r/olkb" aria-label target="_blank" rel="noopener" data-v-7bc22406 data-v-eee4e7cb><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 50 50" width="50px" height="50px"><path d="M 29 3 C 28.0625 3 27.164063 3.382813 26.5 4 C 25.835938 4.617188 25.363281 5.433594 25 6.40625 C 24.355469 8.140625 24.085938 10.394531 24.03125 13.03125 C 19.234375 13.179688 14.820313 14.421875 11.28125 16.46875 C 10.214844 15.46875 8.855469 14.96875 7.5 14.96875 C 6.089844 14.96875 4.675781 15.511719 3.59375 16.59375 C 1.425781 18.761719 1.425781 22.238281 3.59375 24.40625 L 3.84375 24.65625 C 3.3125 26.035156 3 27.488281 3 29 C 3 33.527344 5.566406 37.585938 9.5625 40.4375 C 13.558594 43.289063 19.007813 45 25 45 C 30.992188 45 36.441406 43.289063 40.4375 40.4375 C 44.433594 37.585938 47 33.527344 47 29 C 47 27.488281 46.6875 26.035156 46.15625 24.65625 L 46.40625 24.40625 C 48.574219 22.238281 48.574219 18.761719 46.40625 16.59375 C 45.324219 15.511719 43.910156 14.96875 42.5 14.96875 C 41.144531 14.96875 39.785156 15.46875 38.71875 16.46875 C 35.195313 14.433594 30.800781 13.191406 26.03125 13.03125 C 26.09375 10.546875 26.363281 8.46875 26.875 7.09375 C 27.164063 6.316406 27.527344 5.757813 27.875 5.4375 C 28.222656 5.117188 28.539063 5 29 5 C 29.460938 5 29.683594 5.125 30.03125 5.40625 C 30.378906 5.6875 30.785156 6.148438 31.3125 6.6875 C 32.253906 7.652344 33.695313 8.714844 36.09375 8.9375 C 36.539063 11.238281 38.574219 13 41 13 C 43.75 13 46 10.75 46 8 C 46 5.25 43.75 3 41 3 C 38.605469 3 36.574219 4.710938 36.09375 6.96875 C 34.3125 6.796875 33.527344 6.109375 32.75 5.3125 C 32.300781 4.851563 31.886719 4
<span class="line"><span></span></span>
<span class="line"><span>There are instructions on how to keep your fork updated here:</span></span>
<span class="line"><span></span></span>
<span class="line"><span>[**Best Practices: Your Fork&#39;s Master: Update Often, Commit Never**](newbs_git_using_your_master_branch)</span></span>
<span class="line"><span></span></span>
<span class="line"><span>[Fixing Your Branch](newbs_git_resynchronize_a_branch) will walk you through fixing up your `master` branch moving forward. If you need any help with this just ask.</span></span>
<span class="line"><span></span></span>
<span class="line"><span>Thanks for contributing!</span></span></code></pre></div><h2 id="review-process" tabindex="-1">Review Process <a class="header-anchor" href="#review-process" aria-label="Permalink to &quot;Review Process&quot;"></a></h2><p>In general, we want to see two (or more) approvals that are meaningful (e.g. that have inspected code) before a PR will be considered for merge. These reviews are not limited to collaborators -- any community member willing to put in the time is welcomed (and encouraged). The only difference is that your checkmark won&#39;t be green, and that&#39;s fine!</p><p>Additionally, PR reviews are something that is done in our free time. We are not paid nor compensated for the time we spend reviewing, as it is a labor of love. As such, this means that it can take time for us to get to your Pull Request. Things like family, or life can get in the way of us getting to PRs, and burnout is a serious concern. The QMK firmware repository averages 200 PRs opened and 200 PRs merged every month, so please have patience.</p><h2 id="example-gplv2-header" tabindex="-1">Example GPLv2 Header <a class="header-anchor" href="#example-gplv2-header" aria-label="Permalink to &quot;Example GPLv2 Header&quot;"></a></h2><div class="language- vp-adaptive-theme"><button title="Copy Code" class="copy"></button><span class="lang"></span><pre class="shiki shiki-themes github-light github-dark vp-code"><code><span class="line"><span>/* Copyright 2024 Your Name (@yourgithub)</span></span>
<span class="line"><span> *</span></span>
<span class="line"><span> * This program is free software: you can redistribute it and/or modify</span></span>
<span class="line"><span> * it under the terms of the GNU General Public License as published by</span></span>
<span class="line"><span> * the Free Software Foundation, either version 2 of the License, or</span></span>
<span class="line"><span> * (at your option) any later version.</span></span>
<span class="line"><span> *</span></span>
<span class="line"><span> * This program is distributed in the hope that it will be useful,</span></span>
<span class="line"><span> * but WITHOUT ANY WARRANTY; without even the implied warranty of</span></span>
<span class="line"><span> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span></span>
<span class="line"><span> * GNU General Public License for more details.</span></span>
<span class="line"><span> *</span></span>
<span class="line"><span> * You should have received a copy of the GNU General Public License</span></span>
<span class="line"><span> * along with this program. If not, see &lt;http://www.gnu.org/licenses/&gt;.</span></span>
<span class="line"><span> */</span></span></code></pre></div><p>Or, optionally, using <a href="https://spdx.org/licenses/" target="_blank" rel="noreferrer">SPDX identifier</a> instead:</p><div class="language- vp-adaptive-theme"><button title="Copy Code" class="copy"></button><span class="lang"></span><pre class="shiki shiki-themes github-light github-dark vp-code"><code><span class="line"><span>// Copyright 2024 Your Name (@yourgithub)</span></span>
<span class="line"><span>// SPDX-License-Identifier: GPL-2.0-or-later</span></span></code></pre></div></div></div></main><footer class="VPDocFooter" data-v-39a288b8 data-v-09de1c0f><!--[--><!--]--><div class="edit-info" data-v-09de1c0f><div class="edit-link" data-v-09de1c0f><a class="VPLink link vp-external-link-icon no-icon edit-link-button" href="https://github.com/qmk/qmk_firmware/edit/master/docs/pr_checklist.md" target="_blank" rel="noreferrer" data-v-09de1c0f><!--[--><span class="vpi-square-pen edit-link-icon" data-v-09de1c0f></span> Edit this page<!--]--></a></div><!----></div><nav class="prev-next" data-v-09de1c0f><div class="pager" data-v-09de1c0f><a class="VPLink link pager-link prev" href="/isp_flashing_guide" data-v-09de1c0f><!--[--><span class="desc" data-v-09de1c0f>Previous page</span><span class="title" data-v-09de1c0f>ISP Flashing Guide</span><!--]--></a></div><div class="pager" data-v-09de1c0f><a class="VPLink link pager-link next" href="/breaking_changes" data-v-09de1c0f><!--[--><span class="desc" data-v-09de1c0f>Next page</span><span class="title" data-v-09de1c0f>Overview</span><!--]--></a></div></nav></footer><!--[--><!--]--></div></div></div><!--[--><!--]--></div></div><!----><!--[--><!--]--></div></div>
<script>window.__VP_HASH_MAP__=JSON.parse("{\"changelog_20190830.md\":\"D5Gv0xM2\",\"changelog_20200229.md\":\"TBlkCyr5\",\"changelog_20200530.md\":\"TIsD4IJ6\",\"changelog_20200829.md\":\"DLRic7TT\",\"changelog_20201128.md\":\"Ba_rFlxl\",\"changelog_20210227.md\":\"DvqXERXt\",\"changelog_20210529.md\":\"D6J1RidB\",\"changelog_20210828.md\":\"C3lFgq5A\",\"changelog_20211127.md\":\"KawnpmKg\",\"changelog_20220226.md\":\"KLnmRn9F\",\"changelog_20220528.md\":\"Boue42eA\",\"changelog_20220827.md\":\"BmGjSteF\",\"changelog_20221126.md\":\"B7IFykhd\",\"changelog_20230226.md\":\"twCbPT9A\",\"changelog_20230528.md\":\"BzLLaFNh\",\"changelog_20230827.md\":\"BrhCShVH\",\"changelog_20231126.md\":\"DVLm2eGv\",\"changelog_20240225.md\":\"CXS3FgKU\",\"changelog_20240526.md\":\"BM7fxQBp\",\"changelog_20240825.md\":\"BDFY9wpG\",\"changelog_20241124.md\":\"Q_tHeHAa\",\"capabilities.md\":\"a_Nbgg0n\",\"capabilities_inc.md\":\"Cor-lDIx\",\"api_development_environment.md\":\"pCQRKF_M\",\"api_development_overview.md\":\"D5Zus3EP\",\"api_docs.md\":\"CCHPm9Ph\",\"api_overview.md\":\"Bo6l-c66\",\"arm_debugging.md\":\"DcrpfiyI\",\"breaking_changes.md\":\"y5xbzT8a\",\"breaking_changes_history.md\":\"DnerrifT\",\"breaking_changes_instructions.md\":\"y3u4ruQJ\",\"chibios_upgrade_instructions.md\":\"p6uZF4kP\",\"cli.md\":\"D3UYWDOB\",\"cli_commands.md\":\"DmaB9sac\",\"cli_configuration.md\":\"gftml-GJ\",\"cli_development.md\":\"CV5X2u0i\",\"cli_tab_complete.md\":\"BjhR5TFS\",\"coding_conventions_c.md\":\"DDXrsq6j\",\"coding_conventions_python.md\":\"BpeQIiJ8\",\"compatible_microcontrollers.md\":\"Bp5Cuz5M\",\"config_options.md\":\"C0ey_0zq\",\"configurator_architecture.md\":\"-1IamgaM\",\"configurator_default_keymaps.md\":\"Csbe8pIs\",\"configurator_step_by_step.md\":\"BQXI9udF\",\"configurator_troubleshooting.md\":\"A5MEdd6g\",\"contributing.md\":\"CJpSA-c9\",\"custom_matrix.md\":\"BBjT28gr\",\"custom_quantum_functions.md\":\"7Wtzp8l7\",\"data_driven_config.md\":\"fJsS9ZqH\",\"documentation_best_practices.md\":\"DG91aPmN\",\"documentation_templates.md\":\"C2-rIfQ7\",\"driver_installation_zadig.md\":\"quInZVrl\",\"drivers_adc.md\":\"DEzkLXsb\",\"drivers_apa102.md\":\"DZyCh2Hs\",\"drivers_audio.md\":\"D7D3osxI\",\"drivers_aw20216s.md\":\"CRGZz1xZ\",\"drivers_eeprom.md\":\"D2Ip1OAY\",\"drivers_flash.md\":\"BgL2PtmD\",\"drivers_gpio.md\":\"DMCKpyic\",\"drivers_i2c.md\":\"CZ78jxRE\",\"drivers_is31fl3218.md\":\"DgfDKi5r\",\"drivers_is31fl3236.md\":\"DO7FGjNM\",\"drivers_is31fl3729.md\":\"BmFD_YGz\",\"drivers_is31fl3731.md\":\"k9wXgexF\",\"drivers_is31fl3733.md\":\"CTovyg7g\",\"drivers_is31fl3736.md\":\"C-ibqmvt\",\"drivers_is31fl3737.md\":\"DuW4Ycqu\",\"drivers_is31fl3741.md\":\"Bd8tDEGh\",\"drivers_is31fl3742a.md\":\"o6103t5c\",\"drivers_is31fl3743a.md\":\"e2xEXYVf\",\"drivers_is31fl3745.md\":\"C0VypsOf\",\"drivers_is31fl3746a.md\":\"Dc_MBCTu\",\"drivers_serial.md\":\"CJRpA3ob\",\"drivers_snled27351.md\":\"DkoZ0nOF\",\"drivers_spi.md\":\"vFN5MRzl\",\"drivers_uart.md\":\"DfVpzltt\",\"drivers_ws2812.md\":\"Obzw-GTj\",\"easy_maker.md\":\"yfFLYEZu\",\"faq_build.md\":\"ClAW0aMe\",\"faq_debug.md\":\"DaRqKHet\",\"faq_general.md\":\"0Ixv74_I\",\"faq_keymap.md\":\"BLluC4NV\",\"faq_misc.md\":\"CVtsey6K\",\"feature_advanced_keycodes.md\":\"C2iBp6mf\",\"feature_converters.md\":\"rz_anpjy\",\"feature_debounce_type.md\":\"CYIyyhFB\",\"feature_eeprom.md\":\"Bhzy4RDv\",\"feature_layers.md\":\"B59e5DpO\",\"feature_layouts.md\":\"BK7vfZuH\",\"feature_macros.md\":\"4VvYwf-t\",\"feature_userspace.md\":\"CF52Rhjy\",\"features_audio.md\":\"xQ9VRAsq\",\"features_auto_shift.md\":\"DOcRLWqv\",\"features_autocorrect.md\":\"iXmGH9ee\",\"features_backlight.md\":\"Cvuqwm3F\",\"features_bootmagic.md\":\"BjDrYOUH\",\"features_caps_word.md\":\"CYfZhNN7\",\"features_combo.md\":\"v8KQE72a\",\"features_command.md\":\"ajsjx5Wc\",\"features_digitizer.md\":\"BouFmMBP\",\"features_dip_switch.md\":\"BphpeXE7\",\"features_dynamic_macros.md\":\"CnLDkQKC\",\"features_encoders.md\":\"CGtgEWxD\",\"features_grave_esc.md\":\"DXES6Ttb\",\"features_haptic_feedback.md\":\"COJ0M8E1\",\"features_hd4
</body>
</html>