phoedos/pmd
1
1 Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update JUnit5TestShouldBePackagePrivate to pmd 7

Browse Source 
refs #3247
This commit is contained in:
Clément Fournier committed 2021-05-25 13:30:05 +02:00
1 parent a2ad578039
commit 03e9e840a2
1 file changed
+17 -14
Download Patch File Download Diff File Expand all files Collapse all files
pmd-java/src/main/resources/category/java/bestpractices.xml
+17 -14
View File
@@ -821,23 +821,26 @@ Test methods are identified as those which use `@Test`, `@RepeatedTest`,
<![CDATA[
//ClassOrInterfaceDeclaration[
(: a Junit 5 test class, ie, it has methods with the annotation :)
@Interface=false() and
ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration
[Annotation//Name[
pmd-java:typeIs('org.junit.jupiter.api.Test') or pmd-java:typeIs('org.junit.jupiter.api.RepeatedTest')
or pmd-java:typeIs('org.junit.jupiter.api.TestFactory') or pmd-java:typeIs('org.junit.jupiter.api.TestTemplate')
@Interface = false() and
ClassOrInterfaceBody/MethodDeclaration
[ModifierList/Annotation[
pmd-java:typeIs('org.junit.jupiter.api.Test')
or pmd-java:typeIs('org.junit.jupiter.api.RepeatedTest')
or pmd-java:typeIs('org.junit.jupiter.api.TestFactory')
or pmd-java:typeIs('org.junit.jupiter.api.TestTemplate')
or pmd-java:typeIs('org.junit.jupiter.params.ParameterizedTest')
]]
[MethodDeclaration]
]]
]/(
self::*[@Abstract=false() and (@Public=true() or @Protected=true())]
| ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration
[Annotation//Name[
pmd-java:typeIs('org.junit.jupiter.api.Test') or pmd-java:typeIs('org.junit.jupiter.api.RepeatedTest')
or pmd-java:typeIs('org.junit.jupiter.api.TestFactory') or pmd-java:typeIs('org.junit.jupiter.api.TestTemplate')
self::*[@Abstract = false() and @Visibility = ("public", "protected")]
| ClassOrInterfaceBody/MethodDeclaration
[@Visibility = ("public", "protected")]
[ModifierList/Annotation[
pmd-java:typeIs('org.junit.jupiter.api.Test')
or pmd-java:typeIs('org.junit.jupiter.api.RepeatedTest')
or pmd-java:typeIs('org.junit.jupiter.api.TestFactory')
or pmd-java:typeIs('org.junit.jupiter.api.TestTemplate')
or pmd-java:typeIs('org.junit.jupiter.params.ParameterizedTest')
]]
/MethodDeclaration[@Public=true() or @Protected=true()]
]]
)
]]>
</value>