fixes #1457 TooManyMethods counts inner class methods

This commit is contained in:
Andreas Dangel
2016-02-07 12:31:49 +01:00
parent 89ffb56e4e
commit 079ffeb4df
3 changed files with 35 additions and 1 deletions

View File

@ -495,7 +495,7 @@ have more fine grained objects.
<![CDATA[
//ClassOrInterfaceDeclaration/ClassOrInterfaceBody
[
count(descendant::MethodDeclarator[
count(./ClassOrInterfaceBodyDeclaration/MethodDeclaration/MethodDeclarator[
not (
starts-with(@Image,'get')
or

View File

@ -90,4 +90,36 @@ public class Foo
</code>
</test-code>
<test-code>
<description>#1457 TooManyMethods counts inner class methods</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class OuterClass {
public void method1() {}
public void method2() {}
public void method3() {}
public void method4() {}
public void method5() {}
public void method6() {}
public void method7() {}
public static class InnerClass extends OuterClass {
@Override
public void method1() {}
@Override
public void method2() {}
@Override
public void method3() {}
@Override
public void method4() {}
@Override
public void method5() {}
@Override
public void method6() {}
@Override
public void method7() {}
}
}
]]></code>
</test-code>
</test-data>

View File

@ -25,6 +25,8 @@
**Bugfixes:**
* java-codesize/TooManyMethods:
* [#1457](https://sourceforge.net/p/pmd/bugs/1457/): TooManyMethods counts inner class methods
* java-controversial/AvoidUsingShortType:
* [#1449](https://sourceforge.net/p/pmd/bugs/1449/): false positive when casting a variable to short
* java-design/AccessorClassGeneration: