phoedos/pmd
1
1 Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pmd-eclipse: fix #1116 PMD Eclipse plugin doesn't analyze project if it has non-existing source folders

Browse Source
This commit is contained in:
Andreas Dangel committed 2013-07-23 21:36:58 +02:00
1 parent 989672f8fb
commit 1df96cb2e7
2 files changed
+23 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

pmd-eclipse-plugin/ReleaseNotes.md
+2
View File
@@ -5,7 +5,9 @@ Eclipse Update Site: http://pmd.sourceforge.net/eclipse/
????: 4.0.1.v????
-----------------
* Fixed PMD Eclipse plugin doesn't analyze project if it has non-existing source folders ([bug #1116])
[bug #1116]: http://sourceforge.net/p/pmd/bugs/1116/
10-May-2013: 4.0.0.v20130510-1000
---------------------------------
pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java
+21 -14
View File
@@ -366,24 +366,31 @@ public class ReviewCodeCmd extends AbstractDefaultCommand {
final RuleSet ruleSet = rulesetFrom(resource); //properties.getProjectRuleSet();
// final PMDEngine pmdEngine = getPmdEngineForProject(project);
int targetCount = countResourceElement(resource);
int targetCount = 0;
if (resource.exists()) {
targetCount = countResourceElement(resource);
}
// Could add a property that lets us set the max number to analyze
if (properties.isFullBuildEnabled() || targetCount ==1){
if (properties.isFullBuildEnabled() || targetCount == 1){
setStepCount(targetCount);
log.debug("Visiting resource " + resource.getName() + " : " + getStepCount());
final ResourceVisitor visitor = new ResourceVisitor();
visitor.setMonitor(getMonitor());
visitor.setRuleSet(ruleSet);
// visitor.setPmdEngine(pmdEngine);
visitor.setAccumulator(markersByFile);
visitor.setUseTaskMarker(taskMarker);
visitor.setProjectProperties(properties);
resource.accept(visitor);
ruleCount = ruleSet.getRules().size();
fileCount += visitor.getProcessedFilesCount();
pmdDuration += visitor.getActualPmdDuration();
if (resource.exists()) {
final ResourceVisitor visitor = new ResourceVisitor();
visitor.setMonitor(getMonitor());
visitor.setRuleSet(ruleSet);
// visitor.setPmdEngine(pmdEngine);
visitor.setAccumulator(markersByFile);
visitor.setUseTaskMarker(taskMarker);
visitor.setProjectProperties(properties);
resource.accept(visitor);
ruleCount = ruleSet.getRules().size();
fileCount += visitor.getProcessedFilesCount();
pmdDuration += visitor.getActualPmdDuration();
} else {
log.debug("Skipping resource " + resource.getName() + " because it doesn't exist.");
}
} else {
log.debug("Skipping resource "+ resource.getName()
+ " because of fullBuildEnabled flag");