[java] UnnecessaryFinalModifier final in private method #421

pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/unnecessary/UnnecessaryModifierRule.java

@@ -88,6 +88,9 @@ public class UnnecessaryModifierRule extends AbstractJavaRule {
         if (node.isSyntacticallyPublic() || node.isSyntacticallyAbstract()) {
             check(node, data);
         }
+        if (node.isPrivate() && node.isFinal()) {
+        	addViolation(data, node);
+        }
         return super.visit(node, data);
     }
 

pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UnnecessaryModifier.xml

@@ -428,4 +428,15 @@ public abstract @interface TestAnnotation {
 }
         ]]></code>
     </test-code>
+    <test-code>
+    <description>Unnecessary final of private method</description>
+    <expected-problems>1</expected-problems>
+    <code><![CDATA[
+public class TestClass {
+	private final int getValue() {
+		return 0;
+	}
+}
+    ]]></code>
+</test-code>
 </test-data>