phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

revert changes to InnaccurateNumericLiteral

Browse Source
This commit is contained in:
XenoAmess
2020-08-27 11:49:39 +08:00
parent 244a39db0f
commit 2e258aa529
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/pages/release_notes_old.md
View File

@ -3067,7 +3067,7 @@ This is a minor release.
* [#1173](https://github.com/pmd/pmd/issues/1173): \[core] Some characters in CPD are not shown correctly.
* [#1193](https://github.com/pmd/pmd/issues/1193): \[core] Designer doesn't start with run.sh
* ecmascript
* [#861](https://github.com/pmd/pmd/issues/861): \[ecmascript] InaccurateNumericLiteral false positive with hex literals
* [#861](https://github.com/pmd/pmd/issues/861): \[ecmascript] InnaccurateNumericLiteral false positive with hex literals
* java
* [#1074](https://github.com/pmd/pmd/issues/1074): \[java] MissingOverrideRule exception when analyzing PMD under Java 9
* [#1174](https://github.com/pmd/pmd/issues/1174): \[java] CommentUtil.multiLinesIn() could lead to StringIndexOutOfBoundsException
@ -7647,7 +7647,7 @@ The binary package still contains all languages and can be used as usual. Have a
Basic ruleset: NoInlineScript
New ECMAScript rules:
Basic ruleset: AssignmentInOperand,ConsistentReturn,InaccurateNumericLiteral,ScopeForInVariable,UnreachableCode,EqualComparison,GlobalVariable
Basic ruleset: AssignmentInOperand,ConsistentReturn,InnaccurateNumericLiteral,ScopeForInVariable,UnreachableCode,EqualComparison,GlobalVariable
Braces ruleset: ForLoopsMustUseBraces,IfStmtsMustUseBraces,IfElseStmtsMustUseBraces,WhileLoopsMustUseBraces
Unnecessary ruleset: UnnecessaryParentheses,UnnecessaryBlock

2
pmd-core/src/main/resources/rulesets/releases/50.xml
View File

@ -10,7 +10,7 @@ This ruleset contains links to rules that are new in PMD v5.0
<rule ref="rulesets/ecmascript/basic.xml/AssignmentInOperand"/>
<rule ref="rulesets/ecmascript/basic.xml/ConsistentReturn"/>
<rule ref="rulesets/ecmascript/basic.xml/InaccurateNumericLiteral"/>
<rule ref="rulesets/ecmascript/basic.xml/InnaccurateNumericLiteral"/>
<rule ref="rulesets/ecmascript/basic.xml/UnreachableCode"/>
<rule ref="rulesets/ecmascript/basic.xml/EqualComparison"/>
<rule ref="rulesets/ecmascript/basic.xml/GlobalVariable"/>

4
pmd-javascript/src/main/resources/category/ecmascript/errorprone.xml
View File

@ -93,12 +93,12 @@ if (someVar != 3) {
</example>
</rule>
<rule name="InaccurateNumericLiteral"
<rule name="InnaccurateNumericLiteral"
language="ecmascript"
since="5.0"
message="The numeric literal ''{0}'' will have at different value at runtime."
class="net.sourceforge.pmd.lang.rule.XPathRule"
externalInfoUrl="${pmd.website.baseurl}/pmd_rules_ecmascript_errorprone.html#inaccuratenumericliteral">
externalInfoUrl="${pmd.website.baseurl}/pmd_rules_ecmascript_errorprone.html#innaccuratenumericliteral">
<description>
The numeric literal will have a different value at runtime, which can happen if you provide too much
precision in a floating point number. This may result in numeric calculations being in error.

2
pmd-javascript/src/main/resources/rulesets/ecmascript/basic.xml
View File

@ -12,7 +12,7 @@
<rule ref="category/ecmascript/errorprone.xml/AvoidTrailingComma" deprecated="true" />"
<rule ref="category/ecmascript/errorprone.xml/EqualComparison" deprecated="true" />
<rule ref="category/ecmascript/errorprone.xml/InaccurateNumericLiteral" deprecated="true" />
<rule ref="category/ecmascript/errorprone.xml/InnaccurateNumericLiteral" deprecated="true" />
<rule ref="category/ecmascript/bestpractices.xml/ConsistentReturn" deprecated="true" />
<rule ref="category/ecmascript/bestpractices.xml/GlobalVariable" deprecated="true" />

2
pmd-javascript/src/test/java/net/sourceforge/pmd/lang/ecmascript/rule/errorprone/InaccurateNumericLiteralTest.java
View File

@ -6,6 +6,6 @@ package net.sourceforge.pmd.lang.ecmascript.rule.errorprone;
import net.sourceforge.pmd.testframework.PmdRuleTst;
public class InaccurateNumericLiteralTest extends PmdRuleTst {
public class InnaccurateNumericLiteralTest extends PmdRuleTst {
// no additional unit tests
}

2
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/errorprone/xml/InaccurateNumericLiteral.xml → pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/errorprone/xml/InnaccurateNumericLiteral.xml
View File

@ -51,7 +51,7 @@ var x = 1.12345678901234567e-4;
</test-code>
<test-code>
<description>#861 [ecmascript] InaccurateNumericLiteral false positive</description>
<description>#861 [ecmascript] InnaccurateNumericLiteral false positive</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
var hex1 = 0x20;