Add resource links

pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/util/codearea/UniformStyleCollection.java

@@ -25,7 +25,7 @@ import net.sourceforge.pmd.util.fxdesigner.util.codearea.NodeStyleSpan.PositionS
 
 /**
  * Collection of nodes that share the same style. In case of overlap,
- * the nested ones gain css classes like depth-1, depth-2, etc. A
+ * the nested ones gain css classes like depth-0, depth-1, etc. A
  * collection can be overlaid into a single span in one pass using
  * {@link #toSpans()}.
  *

pmd-ui/src/main/resources/net/sourceforge/pmd/util/fxdesigner/less/constants.less

@@ -1,6 +1,21 @@
 /*
-  App-wide color constants and such.
- */
+  App-wide color constants and useful mixins.
+
+  Useful resources (TODO add that to a doc page on the site):
+
+  * Less reference (we use Less 1.7.0):
+      http://lesscss.org/features/
+
+  * JavaFX CSS reference:
+      https://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html
+
+  * modena.css (base JavaFX stylesheet):
+      http://hg.openjdk.java.net/openjfx/jfx-dev/rt/file/762a57e4b74a/modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css
+
+  * Icon gallery:
+      https://fontawesome.com/icons?d=gallery
+
+*/
 
 // This is repeated to use it from Less
 // Prefer using it over -fx-base

pmd-ui/src/main/resources/net/sourceforge/pmd/util/fxdesigner/less/designer.less

@@ -1,6 +1,6 @@
-/* Useful links: */
-/* http://hg.openjdk.java.net/openjfx/jfx-dev/rt/file/762a57e4b74a/modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css */
-/* https://fontawesome.com/icons?d=gallery */
+/*
+ * Base sheet for the whole app
+ */
 
 @import "constants";
 

pmd-ui/src/main/resources/net/sourceforge/pmd/util/fxdesigner/less/editor-theme.less

@@ -1,15 +1,12 @@
-/* Presets for the editor theme and syntax highlighting. */
-
-/* CSS reference of the code area:
-     https://github.com/FXMisc/RichTextFX/wiki/RichTextFX-CSS-Reference-Guide
-
-   Less reference (we use Less 1.7.0):
-     http://lesscss.org/features/
+/* Presets for the editor theme and syntax highlighting.
 
+   * CSS reference of the code area:
+       https://github.com/FXMisc/RichTextFX/wiki/RichTextFX-CSS-Reference-Guide
 */
 
 @import "constants";
 
+// Each color in this stack corresponds to a depth level in XPath colors
 @xpath-color-stack:
         rgba(249, 248, 113, 0.25),
         rgba(255, 199, 95, 0.4),
@@ -37,6 +34,7 @@
     .make-depth-classes(@depth: length(@xpath-color-stack) - 1) when (@depth >= 0) {
         .make-depth-classes(@depth - 1);
 
+        // the first style class is depth-0, but CSS arrays indices start at 1
         @background: extract(@xpath-color-stack, @depth + 1);
         @border: darken(@background, 30%);
 
@@ -76,10 +74,6 @@
             -fx-background-color: @area-background-color;
             -fx-border-color: @area-background-color;
         }
-
-        .thumb {
-            -fx-background-color: derive(black, 90%);
-        }
     }
 
     .paragraph-box:has-caret {