fixed a bug and removed more unneeded constructors
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@972 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
@ -10,10 +10,6 @@ import net.sourceforge.pmd.rules.DontImportJavaLangRule;
|
||||
|
||||
public class DontImportJavaLangRuleTest extends RuleTst {
|
||||
|
||||
public DontImportJavaLangRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
Report report = process("DontImportJavaLang1.java", new DontImportJavaLangRule());
|
||||
assertEquals(1, report.size());
|
||||
|
@ -11,9 +11,6 @@ import net.sourceforge.pmd.rules.DuplicateImportsRule;
|
||||
import net.sourceforge.pmd.rules.UnusedLocalVariableRule;
|
||||
|
||||
public class DuplicateImportsRuleTest extends RuleTst {
|
||||
public DuplicateImportsRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
private DuplicateImportsRule rule;
|
||||
|
||||
|
@ -13,10 +13,6 @@ import net.sourceforge.pmd.rules.EmptyCatchBlockRule;
|
||||
|
||||
public class EmptyCatchBlockRuleTest extends RuleTst {
|
||||
|
||||
public EmptyCatchBlockRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testEmptyCatchBlock() throws Throwable {
|
||||
Report report = process("EmptyCatchBlock.java", new EmptyCatchBlockRule());
|
||||
assertEquals(1, report.size());
|
||||
|
@ -11,10 +11,6 @@ import net.sourceforge.pmd.rules.EmptyFinallyBlockRule;
|
||||
|
||||
public class EmptyFinallyBlockRuleTest extends RuleTst {
|
||||
|
||||
public EmptyFinallyBlockRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testEmptyFinallyBlock1() throws Throwable {
|
||||
Report report = process("EmptyFinallyBlock1.java", new EmptyFinallyBlockRule());
|
||||
assertEquals(1, report.size());
|
||||
|
@ -11,9 +11,6 @@ import net.sourceforge.pmd.renderers.Renderer;
|
||||
import net.sourceforge.pmd.rules.EmptyIfStmtRule;
|
||||
|
||||
public class EmptyIfStmtRuleTest extends RuleTst {
|
||||
public EmptyIfStmtRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testEmptyIf() throws Throwable {
|
||||
Report report = process("EmptyIfStmtRule.java", new EmptyIfStmtRule());
|
||||
|
@ -9,10 +9,6 @@ import net.sourceforge.pmd.rules.EmptySwitchStmtRule;
|
||||
|
||||
public class EmptySwitchStmtRuleTest extends RuleTst {
|
||||
|
||||
public EmptySwitchStmtRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
runTest("EmptySwitchStmt1.java", 1, new EmptySwitchStmtRule());
|
||||
}
|
||||
|
@ -11,9 +11,6 @@ import net.sourceforge.pmd.rules.EmptyCatchBlockRule;
|
||||
import net.sourceforge.pmd.rules.EmptyTryBlockRule;
|
||||
|
||||
public class EmptyTryBlockRuleTest extends RuleTst {
|
||||
public EmptyTryBlockRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testEmptyTryBlock1() throws Throwable {
|
||||
Report report = process("EmptyTryBlock1.java", new EmptyTryBlockRule());
|
||||
|
@ -11,9 +11,6 @@ import net.sourceforge.pmd.renderers.Renderer;
|
||||
import net.sourceforge.pmd.rules.EmptyWhileStmtRule;
|
||||
|
||||
public class EmptyWhileStmtRuleTest extends RuleTst {
|
||||
public EmptyWhileStmtRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testEmptyWhileStmtRule() throws Throwable {
|
||||
Report report = process("EmptyWhileStmtRule.java", new EmptyWhileStmtRule());
|
||||
|
@ -10,9 +10,6 @@ import net.sourceforge.pmd.rules.WhileLoopsMustUseBracesRule;
|
||||
import net.sourceforge.pmd.rules.ForLoopsMustUseBracesRule;
|
||||
|
||||
public class ForLoopsMustUseBracesRuleTest extends RuleTst {
|
||||
public ForLoopsMustUseBracesRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
Report report = process("ForLoopsNeedBraces1.java", new ForLoopsMustUseBracesRule());
|
||||
|
@ -11,10 +11,6 @@ import net.sourceforge.pmd.Report;
|
||||
|
||||
public class IfElseStmtsMustUseBracesRuleTest extends RuleTst {
|
||||
|
||||
public IfElseStmtsMustUseBracesRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testIfElseStmtsMustUseBraces1() throws Throwable {
|
||||
Report report = process("IfElseStmtsNeedBraces1.java", new IfElseStmtsMustUseBracesRule());
|
||||
assertEquals(1, report.size());
|
||||
|
@ -9,9 +9,6 @@ import net.sourceforge.pmd.rules.IfStmtsMustUseBracesRule;
|
||||
|
||||
public class IfStmtsMustUseBracesRuleTest extends RuleTst {
|
||||
|
||||
public IfStmtsMustUseBracesRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
runTest("IfStmtsMustUseBraces1.java", 1, new IfStmtsMustUseBracesRule());
|
||||
|
@ -12,9 +12,6 @@ public class JUnitSpellingRuleTest extends RuleTst {
|
||||
|
||||
private Rule rule;
|
||||
|
||||
public JUnitSpellingRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new JUnitSpellingRule();
|
||||
|
@ -9,10 +9,6 @@ import net.sourceforge.pmd.rules.JUnitStaticSuiteRule;
|
||||
|
||||
public class JUnitStaticSuiteRuleTest extends RuleTst {
|
||||
|
||||
public JUnitStaticSuiteRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
runTest("JUnitStaticSuite1.java", 2, new JUnitStaticSuiteRule());
|
||||
}
|
||||
|
@ -14,10 +14,6 @@ public class LongVariableRuleTest
|
||||
|
||||
private LongVariableRule rule;
|
||||
|
||||
public LongVariableRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new LongVariableRule();
|
||||
rule.setMessage("Avoid long names like {0}");
|
||||
|
@ -11,10 +11,6 @@ import net.sourceforge.pmd.rules.OverrideBothEqualsAndHashcodeRule;
|
||||
import net.sourceforge.pmd.Report;
|
||||
|
||||
public class OverrideBothEqualsAndHashcodeRuleTest extends RuleTst {
|
||||
public OverrideBothEqualsAndHashcodeRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public void test1() throws Throwable{
|
||||
Report report = process("OverrideBothEqualsAndHashcode1.java", new OverrideBothEqualsAndHashcodeRule());
|
||||
assertEquals(1, report.size());
|
||||
|
@ -23,10 +23,6 @@ import net.sourceforge.pmd.ast.*;
|
||||
public class RuleTst
|
||||
extends TestCase
|
||||
{
|
||||
public RuleTst( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public Report process( String fileName,
|
||||
Rule rule )
|
||||
throws Throwable
|
||||
|
@ -14,10 +14,6 @@ public class ShortMethodNameRuleTest
|
||||
|
||||
private ShortMethodNameRule rule;
|
||||
|
||||
public ShortMethodNameRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new ShortMethodNameRule();
|
||||
rule.setMessage("Avoid this stuff -> {0}");
|
||||
|
@ -14,10 +14,6 @@ public class ShortVariableRuleTest
|
||||
|
||||
private ShortVariableRule rule;
|
||||
|
||||
public ShortVariableRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new ShortVariableRule();
|
||||
rule.setMessage("Avoid stuff like -> ''{0}''");
|
||||
|
@ -9,9 +9,6 @@ import net.sourceforge.pmd.Report;
|
||||
import net.sourceforge.pmd.rules.SimplifyBooleanReturnsRule;
|
||||
|
||||
public class SimplifyBooleanReturnsRuleTest extends RuleTst {
|
||||
public SimplifyBooleanReturnsRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
Report report = process("SimplifyBooleanReturns1.java", new SimplifyBooleanReturnsRule());
|
||||
|
@ -9,10 +9,6 @@ import net.sourceforge.pmd.rules.StringInstantiationRule;
|
||||
|
||||
public class StringInstantiationRuleTest extends RuleTst {
|
||||
|
||||
public StringInstantiationRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
runTest("StringInstantiation1.java", 2, new StringInstantiationRule());
|
||||
}
|
||||
@ -20,4 +16,8 @@ public class StringInstantiationRuleTest extends RuleTst {
|
||||
public void test2() throws Throwable {
|
||||
runTest("StringInstantiation2.java", 0, new StringInstantiationRule());
|
||||
}
|
||||
|
||||
public void test3() throws Throwable {
|
||||
runTest("StringInstantiation3.java", 0, new StringInstantiationRule());
|
||||
}
|
||||
}
|
||||
|
@ -9,10 +9,6 @@ import net.sourceforge.pmd.rules.SwitchStmtsShouldHaveDefaultRule;
|
||||
|
||||
public class SwitchStmtsShouldHaveDefaultRuleTest extends RuleTst {
|
||||
|
||||
public SwitchStmtsShouldHaveDefaultRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
runTest("SwitchStmtsShouldHaveDefault1.java", 1, new SwitchStmtsShouldHaveDefaultRule());
|
||||
}
|
||||
|
@ -13,10 +13,6 @@ import net.sourceforge.pmd.rules.UnnecessaryConversionTemporaryRule;
|
||||
|
||||
public class UnnecessaryTemporariesRuleTest extends RuleTst{
|
||||
|
||||
public UnnecessaryTemporariesRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void testUnnecessaryTemporaries() throws Throwable {
|
||||
Report report = process("UnnecessaryTemporary.java", new UnnecessaryConversionTemporaryRule());
|
||||
assertEquals(6, report.size());
|
||||
|
@ -9,9 +9,6 @@ import net.sourceforge.pmd.rules.UnusedImportsRule;
|
||||
import net.sourceforge.pmd.Report;
|
||||
|
||||
public class UnusedImportsRuleTest extends RuleTst {
|
||||
public UnusedImportsRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
private UnusedImportsRule rule;
|
||||
|
||||
|
@ -18,10 +18,6 @@ public class UnusedLocalVariableTest extends RuleTst {
|
||||
|
||||
private UnusedLocalVariableRule rule;
|
||||
|
||||
public UnusedLocalVariableTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new UnusedLocalVariableRule();
|
||||
rule.setMessage("Avoid this stuff -> ''{0}''");
|
||||
|
@ -17,10 +17,6 @@ public class UnusedPrivateInstanceVariableRuleTest extends RuleTst {
|
||||
|
||||
private UnusedPrivateInstanceVariableRule rule;
|
||||
|
||||
public UnusedPrivateInstanceVariableRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new UnusedPrivateInstanceVariableRule();
|
||||
rule.setMessage("Avoid this stuff -> ''{0}''");
|
||||
|
@ -11,10 +11,6 @@ import net.sourceforge.pmd.Report;
|
||||
public class UnusedPrivateMethodRuleTest extends RuleTst {
|
||||
private UnusedPrivateMethodRule rule;
|
||||
|
||||
public UnusedPrivateMethodRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void setUp() {
|
||||
rule = new UnusedPrivateMethodRule();
|
||||
rule.setMessage("Avoid this stuff -> ''{0}''");
|
||||
|
@ -9,9 +9,6 @@ import net.sourceforge.pmd.Report;
|
||||
import net.sourceforge.pmd.rules.WhileLoopsMustUseBracesRule;
|
||||
|
||||
public class WhileLoopsMustUseBracesRuleTest extends RuleTst {
|
||||
public WhileLoopsMustUseBracesRuleTest(String name) {
|
||||
super(name);
|
||||
}
|
||||
|
||||
public void test1() throws Throwable {
|
||||
Report report = process("WhileLoopsNeedBraces1.java", new WhileLoopsMustUseBracesRule());
|
||||
|
@ -10,9 +10,7 @@ import test.net.sourceforge.pmd.rules.RuleTst;
|
||||
public class LongClassRuleTest
|
||||
extends RuleTst
|
||||
{
|
||||
public LongClassRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
|
||||
public LongClassRule getIUT() {
|
||||
LongClassRule IUT = new LongClassRule();
|
||||
|
@ -10,9 +10,6 @@ import test.net.sourceforge.pmd.rules.RuleTst;
|
||||
public class LongMethodRuleTest
|
||||
extends RuleTst
|
||||
{
|
||||
public LongMethodRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public LongMethodRule getIUT() {
|
||||
LongMethodRule IUT = new LongMethodRule();
|
||||
|
@ -10,10 +10,6 @@ import test.net.sourceforge.pmd.rules.RuleTst;
|
||||
public class LongParameterListRuleTest
|
||||
extends RuleTst
|
||||
{
|
||||
public LongParameterListRuleTest( String name ) {
|
||||
super( name );
|
||||
}
|
||||
|
||||
public LongParameterListRule getIUT() {
|
||||
LongParameterListRule IUT = new LongParameterListRule();
|
||||
IUT.addProperty("minimum", "9");
|
||||
|
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user