phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Using EnumSet

Browse Source
This commit is contained in:
Sergey
2017-02-28 14:08:25 -08:00
committed by Juan Martín Sotuyo Dodero
parent eb3fe1ed08
commit 4c748d961f
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java
View File

@ -4,7 +4,7 @@
package net.sourceforge.pmd.lang.vf.rule.security;
import java.util.Arrays;
import java.util.EnumSet;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
@ -64,7 +64,7 @@ public class VfUnescapeElRule extends AbstractVfRule {
final List<ASTElExpression> elsInVal = attr.findDescendantsOfType(ASTElExpression.class);
for (ASTElExpression el : elsInVal) {
if (doesElContainAnyUnescapedIdentifiers(el,
Arrays.asList(ESCAPING.JSINHTMLENCODE, ESCAPING.JSENCODE))) {
EnumSet.of(ESCAPING.JSINHTMLENCODE, ESCAPING.JSENCODE))) {
isEL = true;
toReport.add(el);
}
@ -184,11 +184,12 @@ public class VfUnescapeElRule extends AbstractVfRule {
}
private boolean doesElContainAnyUnescapedIdentifiers(final ASTElExpression elExpression, ESCAPING escape) {
return doesElContainAnyUnescapedIdentifiers(elExpression, Arrays.asList(escape));
return doesElContainAnyUnescapedIdentifiers(elExpression, EnumSet.of(escape));
}
private boolean doesElContainAnyUnescapedIdentifiers(final ASTElExpression elExpression, List<ESCAPING> escapes) {
private boolean doesElContainAnyUnescapedIdentifiers(final ASTElExpression elExpression,
EnumSet<ESCAPING> escapes) {
if (elExpression == null) {
return false;
}