phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merging from eclipse-v2 branch

Browse Source 
Simplify the code : moving the deep nested CountVisitor class as a first level nested inner class.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@2353 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Philippe Herlin
2003-10-30 23:27:59 +00:00
parent 6cf5ecdc6c
commit 703c59215b
1 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
pmd-eclipse/src/net/sourceforge/pmd/eclipse/actions/PMDCheckAction.java
View File

@ -34,6 +34,10 @@ import org.eclipse.ui.IWorkbenchPart;
* @version $Revision$
*
* $Log$
* Revision 1.9 2003/10/30 23:27:59 phherlin
* Merging from eclipse-v2 branch
* Simplify the code : moving the deep nested CountVisitor class as a first level nested inner class.
*
* Revision 1.8 2003/08/13 20:08:40 phherlin
* Refactoring private->protected to remove warning about non accessible member access in enclosing types
*
@ -85,6 +89,24 @@ public class PMDCheckAction implements IObjectActionDelegate {
public void selectionChanged(IAction action, ISelection selection) {
}
// Inner visitor to count number of childs of a resource
private class CountVisitor implements IResourceVisitor {
public int count = 0;
public boolean visit(IResource resource) {
boolean fVisitChildren = true;
count++;
if ((resource instanceof IFile)
&& (((IFile) resource).getFileExtension() != null)
&& ((IFile) resource).getFileExtension().equals("java")) {
fVisitChildren = false;
}
return fVisitChildren;
}
};
// Inner class to run PMD in a thread
private class CheckPMDTask implements IRunnableWithProgress {
private ISelection sel;
@ -149,23 +171,6 @@ public class PMDCheckAction implements IObjectActionDelegate {
* @return the element count
*/
private int countElement(IStructuredSelection selection) {
final class CountVisitor implements IResourceVisitor {
public int count = 0;
public boolean visit(IResource resource) {
boolean fVisitChildren = true;
count++;
if ((resource instanceof IFile)
&& (((IFile) resource).getFileExtension() != null)
&& ((IFile) resource).getFileExtension().equals("java")) {
fVisitChildren = false;
}
return fVisitChildren;
}
};
CountVisitor visitor = new CountVisitor();
for (Iterator i = selection.iterator(); i.hasNext();) {