phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[java] UnnecessaryFullyQualifiedName: check for package name java.lang

Browse Source
This commit is contained in:
Andreas Dangel
2018-06-23 10:15:54 +02:00
parent 4e4c9a194d
commit 70a03a6a68
2 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UnnecessaryFullyQualifiedNameRule.java
View File

@ -17,7 +17,7 @@ import net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit;
import net.sourceforge.pmd.lang.java.ast.ASTImportDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTName;
import net.sourceforge.pmd.lang.java.ast.ASTPackageDeclaration;
import net.sourceforge.pmd.lang.java.ast.JavaNode;
import net.sourceforge.pmd.lang.java.ast.AbstractJavaTypeNode;
import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
import net.sourceforge.pmd.lang.java.symboltable.SourceFileScope;
@ -79,7 +79,7 @@ public class UnnecessaryFullyQualifiedNameRule extends AbstractJavaRule {
&& name.lastIndexOf('.') == decl.getImportedName().length();
}
private void checkImports(JavaNode node, Object data) {
private void checkImports(AbstractJavaTypeNode node, Object data) {
String name = node.getImage();
List<ASTImportDeclaration> matches = new ArrayList<>();
@ -142,7 +142,7 @@ public class UnnecessaryFullyQualifiedNameRule extends AbstractJavaRule {
}
}
if (matches.isEmpty() && isJavaLangImplicit(name)) {
if (matches.isEmpty() && isJavaLangImplicit(node)) {
addViolation(data, node, new Object[] { node.getImage(), "java.lang.*", "implicit "});
}
@ -159,12 +159,22 @@ public class UnnecessaryFullyQualifiedNameRule extends AbstractJavaRule {
}
}
private boolean isJavaLangImplicit(String name) {
// only java.lang.* is implicitly imported, but not e.g. java.lang.reflection.*
return name != null && name.startsWith("java.lang.") && StringUtils.countMatches(name, '.') == 2;
private boolean isJavaLangImplicit(AbstractJavaTypeNode node) {
String name = node.getImage();
boolean isJavaLang = name != null && name.startsWith("java.lang.");
if (isJavaLang && node.getType() != null) {
// valid would be ProcessBuilder.Redirect.PIPE but not java.lang.ProcessBuilder.Redirect.PIPE
String packageName = node.getType().getPackage().getName();
return "java.lang".equals(packageName);
} else if (isJavaLang) {
// only java.lang.* is implicitly imported, but not e.g. java.lang.reflection.*
return StringUtils.countMatches(name, '.') == 2;
}
return false;
}
private boolean isAvoidingConflict(final JavaNode node, final String name,
private boolean isAvoidingConflict(final AbstractJavaTypeNode node, final String name,
final ASTImportDeclaration firstMatch) {
// is it a conflict between different imports?
if (firstMatch.isImportOnDemand() && firstMatch.isStatic()) {

13
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryFullyQualifiedName.xml
View File

@ -424,6 +424,19 @@ import org.foo.String;
public class JavaLang {
public void convert(java.lang.String s) { // no violation
}
}
]]></code>
</test-code>
<test-code>
<description>#1186 [java] UnnecessaryFullyQualifiedName doesn't detect java.lang FQ names as violations: static members of classes in java.lang</description>
<expected-problems>1</expected-problems>
<code><![CDATA[
public class JavaLang {
public void foo() {
ProcessBuilder pb = new ProcessBuilder("echo");
pb.redirectError(java.lang.ProcessBuilder.Redirect.DISCARD); // violation
}
}
]]></code>
</test-code>