phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use ASTAnyTypeDeclaration.getTypeKind()

Browse Source
This commit is contained in:
Andreas Dangel
2018-06-13 20:08:03 +02:00
parent 78c437bf93
commit 88ac2f5227
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/CommentDefaultAccessModifierRule.java
View File

@ -9,11 +9,11 @@ import java.util.List;
import java.util.Set;
import net.sourceforge.pmd.lang.java.ast.ASTAnnotation;
import net.sourceforge.pmd.lang.java.ast.ASTAnyTypeDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceBodyDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit;
import net.sourceforge.pmd.lang.java.ast.ASTConstructorDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTEnumDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTFieldDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTMethodDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTMethodDeclarator;
@ -93,12 +93,11 @@ public class CommentDefaultAccessModifierRule extends AbstractCommentRule {
private boolean shouldReport(final AbstractJavaAccessNode decl) {
final AbstractAnyTypeDeclaration parentClassOrInterface = decl
.getFirstParentOfType(AbstractAnyTypeDeclaration.class);
final boolean isConcreteClass = parentClassOrInterface instanceof ASTClassOrInterfaceDeclaration
&& !((ASTClassOrInterfaceDeclaration) parentClassOrInterface).isInterface();
final boolean isEnumConstructor = parentClassOrInterface instanceof ASTEnumDeclaration
boolean isConcreteClass = parentClassOrInterface.getTypeKind() == ASTAnyTypeDeclaration.TypeKind.CLASS;
boolean isEnumConstructor = parentClassOrInterface.getTypeKind() == ASTAnyTypeDeclaration.TypeKind.ENUM
&& decl instanceof ASTConstructorDeclaration;
// ignore if it's an Interface / Annotation / Enum constructor
return (isConcreteClass || !isEnumConstructor)
// check if the field/method/nested class has a default access