phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bug with empty value strings

Browse Source
This commit is contained in:
oowekyala
2017-07-12 20:00:32 +02:00
parent 9a2a91115b
commit 9075cb005c
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/properties/AbstractMultiValueProperty.java
View File

@ -13,6 +13,7 @@ import java.util.regex.Pattern;
import net.sourceforge.pmd.MultiValuePropertyDescriptor;
import net.sourceforge.pmd.PropertyDescriptorField;
import net.sourceforge.pmd.Rule;
import net.sourceforge.pmd.util.StringUtil;
/**
* Multi-valued property.
@ -176,11 +177,15 @@ import net.sourceforge.pmd.Rule;
@Override
public List<V> valueFrom(String valueString) throws IllegalArgumentException {
if (StringUtil.isEmpty(valueString)) {
return Collections.emptyList();
}
String[] strValues = valueString.split(Pattern.quote("" + multiValueDelimiter()));
List<V> values = new ArrayList<>(strValues.length);
for (int i = 0; i < strValues.length; i++) {
values.add(createFrom(strValues[i]));
for (String strValue : strValues) {
values.add(createFrom(strValue));
}
return values;