phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'pr-192' into pmd/5.5.x

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2017-01-16 18:26:24 -03:00
parent 78fab2e826 291698cdbc
commit 92f7d35bed
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexOpenRedirectRule.java
View File

@ -101,9 +101,11 @@ public class ApexOpenRedirectRule extends AbstractApexRule {
}
} else {
if (node instanceof ASTField) {
/* sergey.gorbaty:
* Apex Jorje parser is returning a null from Field.getFieldInfo(), but the info is available from an inner field.
* DO NOT attempt to optimize this block without checking that Jorje parser actually fixed its bug.
/*
* sergey.gorbaty: Apex Jorje parser is returning a null from
* Field.getFieldInfo(), but the info is available from an inner
* field. DO NOT attempt to optimize this block without checking
* that Jorje parser actually fixed its bug.
*
*/
try {
@ -143,13 +145,6 @@ public class ApexOpenRedirectRule extends AbstractApexRule {
}
}
private void addVariable(AbstractApexNode<?> node) {
ASTVariableExpression variable = node.getFirstChildOfType(ASTVariableExpression.class);
if (variable != null) {
listOfStringLiteralVariables.add(Helper.getFQVariableName(variable));
}
}
/**
* Traverses all new declarations to find PageReferences
*

1
src/site/markdown/overview/changelog.md
View File

@ -233,4 +233,5 @@ to avoid XSS attacks.
* [#184](https://github.com/pmd/pmd/pull/184): \[apex] Improving open redirect detection for static fields & assignment operations
* [#189](https://github.com/pmd/pmd/pull/189): \[apex] Bug fix of SOQL concatenated vars detection
* [#191](https://github.com/pmd/pmd/pull/191): \[apex] Detection of sharing violation when Database. methods are used
* [#192](https://github.com/pmd/pmd/pull/192): \[apex] Dead code removal