phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleaned up

Browse Source
This commit is contained in:
Clément Fournier
2017-03-22 22:50:14 +01:00
committed by Juan Martín Sotuyo Dodero
parent c63d8f3191
commit 94e3e25c03
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/UseStringBufferForStringAppendsRule.java
+4 -5
View File
@@ -18,7 +18,7 @@ import net.sourceforge.pmd.lang.symboltable.NameOccurrence;
import net.sourceforge.pmd.lang.java.typeresolution.TypeHelper;
public class UseStringBufferForStringAppendsRule extends AbstractJavaRule {
@Override
public Object visit(ASTVariableDeclaratorId node, Object data) {
if (!TypeHelper.isA(node, String.class) || node.isArray()) {
@@ -45,13 +45,12 @@ public class UseStringBufferForStringAppendsRule extends AbstractJavaRule {
continue;
}
ASTConditionalExpression conditional = name.getFirstParentOfType(ASTConditionalExpression.class);
if (conditional != null
&& (name.jjtGetParent().jjtGetParent().jjtGetParent() == conditional
|| name.jjtGetParent().jjtGetParent().jjtGetParent().jjtGetParent() == conditional)
Node thirdParent = name.jjtGetParent().jjtGetParent().jjtGetParent();
if (conditional != null && (thirdParent == conditional || thirdParent.jjtGetParent() == conditional)
&& conditional.getFirstParentOfType(ASTStatementExpression.class) == statement) {
// is used in ternary as only option (not appended to other
// string)
continue;
}
if (statement.jjtGetNumChildren() > 0 && statement.jjtGetChild(0) instanceof ASTPrimaryExpression) {