Merge pull request #3264 from oowekyala:issue2780-doc-DataClass

[java] Fix #2780 DataClass example from documentation results in false
negative

docs/pages/release_notes.md

@@ -42,13 +42,14 @@ This is a {{ site.pmd.release_type }} release.
     *   [#3262](https://github.com/pmd/pmd/pull/3262): \[java] FieldDeclarationsShouldBeAtStartOfClass: false negative with anon classes
     *   [#3265](https://github.com/pmd/pmd/pull/3265): \[java] MethodArgumentCouldBeFinal: false negatives with interfaces and inner classes
     *   [#3266](https://github.com/pmd/pmd/pull/3266): \[java] LocalVariableCouldBeFinal: false negatives with interfaces, anon classes
+*   java-design
+    *   [#2780](https://github.com/pmd/pmd/issues/2780): \[java] DataClass example from documentation results in false-negative
 *   java-errorprone
     *   [#3248](https://github.com/pmd/pmd/issues/3248): \[java] Documentation is wrong for SingletonClassReturningNewInstance rule
     *   [#3110](https://github.com/pmd/pmd/issues/3110): \[java] Enhance CompareObjectsWithEquals with list of exceptions
     *   [#3205](https://github.com/pmd/pmd/issues/3205): \[java] Make CompareObjectWithEquals allow comparing against constants
 
 
-
 ### API Changes
 
 ### External Contributions

pmd-java/src/main/resources/category/java/design.xml

@@ -512,10 +512,14 @@ into the former client classes.
 <![CDATA[
 public class DataClass {
 
+  // class exposes public attributes
+  public String name = "";
   public int bar = 0;
   public int na = 0;
+
   private int bee = 0;
 
+  // and private ones through getters
   public void setBee(int n) {
     bee = n;
   }

pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/DataClass.xml

@@ -220,4 +220,28 @@ public class Foo {
 }
         ]]></code>
     </test-code>
+    <test-code>
+        <description>Example from the documentation</description>
+        <expected-problems>1</expected-problems>
+        <expected-messages>
+            <message>The class 'DataClass' is suspected to be a Data Class (WOC=0.000%, NOPA=3, NOAM=1, WMC=1)</message>
+        </expected-messages>
+        <code>
+            <![CDATA[
+            public class DataClass {
+
+                // class exposes public attributes
+                public String name = "";
+                public int bar = 0;
+                public int na = 0;
+
+                private int bee = 0;
+
+                // and private ones through getters
+                public void setBee(int n) {
+                    bee = n;
+                }
+            }
+        ]]></code>
+    </test-code>
 </test-data>