phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tests regarding array accesses

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2024-08-18 19:41:06 -03:00
parent 4352b53aec
commit 9ef927067e
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/GuardLogStatementRule.java
View File

@ -15,6 +15,7 @@ import java.util.Map;
import org.checkerframework.checker.nullness.qual.Nullable;
import net.sourceforge.pmd.lang.java.ast.ASTArgumentList;
import net.sourceforge.pmd.lang.java.ast.ASTArrayAccess;
import net.sourceforge.pmd.lang.java.ast.ASTAssignableExpr.ASTNamedReferenceExpr;
import net.sourceforge.pmd.lang.java.ast.ASTExpression;
import net.sourceforge.pmd.lang.java.ast.ASTExpressionStatement;
@ -239,9 +240,14 @@ public class GuardLogStatementRule extends AbstractJavaRulechainRule {
// so that we can ignore it
return call.getArguments().toStream()
.drop(messageArgIndex) // remove the level argument if needed
.all(it -> it instanceof ASTStringLiteral || it instanceof ASTLambdaExpression
|| it instanceof ASTVariableAccess || it instanceof ASTMethodReference
|| it instanceof ASTFieldAccess || it instanceof ASTThisExpression);
.all(GuardLogStatementRule::isDirectAccess);
}
private static boolean isDirectAccess(ASTExpression it) {
return it instanceof ASTStringLiteral || it instanceof ASTLambdaExpression
|| it instanceof ASTVariableAccess || it instanceof ASTMethodReference
|| it instanceof ASTFieldAccess || it instanceof ASTThisExpression
|| (it instanceof ASTArrayAccess && isDirectAccess(((ASTArrayAccess) it).getQualifier()) );
}
private void extractProperties() {