phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added a test to verify the *TypeParamIndex configuration properties.

Browse Source
This commit is contained in:
Scott Wells
2021-10-21 16:37:07 -05:00
parent 2e0ea71617
commit b07686ae43
1 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml
View File

@@ -1441,6 +1441,54 @@ public class Foo {
AuthorizationUtil.assertMergeable(Account.SObjectType);
Database.merge(masterAccount, mergeAccount, false);
}
}
]]></code>
</test-code>
<test-code>
<description>>#3576 - Verify use of *AuthMethodTypeParamIndex</description>
<rule-property name="createAuthMethodPattern">SomeAuthUtil\.canCreate\w+</rule-property>
<rule-property name="createAuthMethodTypeParamIndex">1</rule-property>
<rule-property name="readAuthMethodPattern">SomeAuthUtil\.canRead\w+</rule-property>
<rule-property name="readAuthMethodTypeParamIndex">2</rule-property>
<rule-property name="updateAuthMethodPattern">SomeAuthUtil\.canUpdate\w+</rule-property>
<rule-property name="updateAuthMethodTypeParamIndex">3</rule-property>
<rule-property name="deleteAuthMethodPattern">SomeAuthUtil\.canDelete\w+</rule-property>
<rule-property name="deleteAuthMethodTypeParamIndex">4</rule-property>
<rule-property name="undeleteAuthMethodPattern">SomeAuthUtil\.canUndelete\w+</rule-property>
<rule-property name="undeleteAuthMethodTypeParamIndex">0</rule-property>
<rule-property name="mergeAuthMethodPattern">SomeAuthUtil\.canMerge\w+</rule-property>
<!--<rule-property name="mergeAuthMethodTypeParamIndex">0</rule-property>--><!-- Unspecified; should be 0 -->
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
public void foo() {
if (SomeAuthUtil.canCreateWithTypeAsSecondParam(param1, Account.SObjectType)) {
insert new List<Account>(new Account(Name = 'X'));
}
if (SomeAuthUtil.canReadWithTypeAsThirdParam(param1, param2, Account.SObjectType)) {
List<Account> accounts = [SELECT Id FROM Account];
}
if (SomeAuthUtil.canUpdateWithTypeAsFourthParam(param1, param2, param3, Account.SObjectType)) {
update new List<Account>(new Account(Name = 'X'));
}
if (SomeAuthUtil.canDeleteWithTypeAsFifthParam(param1, param2, param3, param4, Account.SObjectType)) {
delete new List<Account>(new Account(Name = 'X'));
}
if (SomeAuthUtil.canUndeleteWithTypeAsFirstParamExplicit(Account.SObjectType)) {
undelete new List<Account>(new Account(Name = 'X'));
}
Account masterAccount;
Account mergeAccount;
if (SomeAuthUtil.canMergeWithTypeAsFirstParamImplicit(Account.SObjectType)) {
merge masterAccount mergeAccount;
}
}
}
]]></code>
</test-code>