phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[doc] AutoClosable -> AutoCloseable

Browse Source
This commit is contained in:
Andrey Bozhko
2023-09-06 16:50:16 +00:00
parent 512d6cbb8d
commit ba35bdc6bc
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/resources/category/java/errorprone.xml
View File

@@ -977,7 +977,7 @@ Ensure that resources (like `java.sql.Connection`, `java.sql.Statement`, and `ja
and any subtype of `java.lang.AutoCloseable`) are always closed after use.
Failing to do so might result in resource leaks.
Note: It suffices to configure the super type, e.g. `java.lang.AutoClosable`, so that this rule automatically triggers
Note: It suffices to configure the super type, e.g. `java.lang.AutoCloseable`, so that this rule automatically triggers
on any subtype (e.g. `java.io.FileInputStream`). Additionally specifying `java.sql.Connection` helps in detecting
the types, if the type resolution / auxclasspath is not correctly setup.

6
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UseTryWithResources.xml
View File

@@ -182,13 +182,13 @@ public class TryWithResources {
<code><![CDATA[
public class TryWithResources {
public void run() {
var noAutoclosable = new Object() {
var noAutoCloseable = new Object() {
public void close() {}
};
try {
System.out.println(noAutocloseable);
System.out.println(noAutoCloseable);
} finally {
noAutoclosable.close();
noAutoCloseable.close();
}
}
}

2
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/CloseResource.xml
View File

@@ -1133,7 +1133,7 @@ public class CloseResourceJMS {
</test-code>
<test-code>
<description>CloseResource for closable - ignored if the types do not contain AutoClosable</description>
<description>CloseResource for closable - ignored if the types do not contain AutoCloseable</description>
<rule-property name="types">java.sql.Connection,java.sql.Statement,java.sql.ResultSet</rule-property>
<expected-problems>0</expected-problems>
<code><![CDATA[