phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: rm redundant cast, StringBuffer->StringBuilder updates

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7642 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Brian Remedios
2012-03-12 16:54:13 +00:00
parent 47413a2671
commit bd79c60d85
6 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pmd/src/main/java/net/sourceforge/pmd/cpd/AnyTokenizer.java
View File

@ -19,7 +19,7 @@ public class AnyTokenizer implements Tokenizer {
public static final String TOKENS = " \t!#$%^&*(){}-=+<>/\\`~;:";
public void tokenize(SourceCode sourceCode, Tokens tokenEntries) {
StringBuffer sb = sourceCode.getCodeBuffer();
StringBuilder sb = sourceCode.getCodeBuffer();
BufferedReader reader = new BufferedReader(new CharArrayReader(sb.toString().toCharArray()));
try {
int lineNumber = 1;

2
pmd/src/main/java/net/sourceforge/pmd/cpd/CPPTokenizer.java
View File

@ -15,7 +15,7 @@ import net.sourceforge.pmd.util.IOUtil;
public class CPPTokenizer implements Tokenizer {
public void tokenize(SourceCode sourceCode, Tokens tokenEntries) {
StringBuffer buffer = sourceCode.getCodeBuffer();
StringBuilder buffer = sourceCode.getCodeBuffer();
StringReader reader = null;
try {
LanguageVersionHandler languageVersionHandler = LanguageVersion.CPP.getLanguageVersionHandler();

2
pmd/src/main/java/net/sourceforge/pmd/cpd/JSPTokenizer.java
View File

@ -13,7 +13,7 @@ import net.sourceforge.pmd.lang.jsp.ast.Token;
public class JSPTokenizer implements Tokenizer {
public void tokenize(SourceCode sourceCode, Tokens tokenEntries) {
StringBuffer buffer = sourceCode.getCodeBuffer();
StringBuilder buffer = sourceCode.getCodeBuffer();
LanguageVersionHandler languageVersionHandler = Language.JSP.getDefaultVersion().getLanguageVersionHandler();
TokenManager tokenMgr = languageVersionHandler.getParser(languageVersionHandler.getDefaultParserOptions())
.getTokenManager(sourceCode.getFileName(), new StringReader(buffer.toString()));

2
pmd/src/main/java/net/sourceforge/pmd/cpd/JavaTokenizer.java
View File

@ -26,7 +26,7 @@ public class JavaTokenizer implements Tokenizer {
}
public void tokenize(SourceCode sourceCode, Tokens tokenEntries) {
StringBuffer buffer = sourceCode.getCodeBuffer();
StringBuilder buffer = sourceCode.getCodeBuffer();
/*
I'm doing a sort of State pattern thing here where

7
pmd/src/main/java/net/sourceforge/pmd/cpd/SourceCode.java
View File

@ -113,12 +113,11 @@ public class SourceCode {
return cl.getCode();
}
public StringBuffer getCodeBuffer() {
StringBuffer sb = new StringBuffer();
public StringBuilder getCodeBuffer() {
StringBuilder sb = new StringBuilder();
List<String> lines = cl.getCode();
for (String line : lines) {
sb.append(line);
sb.append(PMD.EOL);
sb.append(line).append(PMD.EOL);
}
return sb;
}

2
pmd/src/main/java/net/sourceforge/pmd/util/TypeMap.java
View File

@ -137,7 +137,7 @@ public class TypeMap {
* @param value
*/
private void storeShortest(Map<Class<?>, String> map, Class<?> key, String value) {
String existingValue = (String) map.get(key);
String existingValue = map.get(key);
if (existingValue == null) {
map.put(key, value);