phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed location for AssignmentToNonFinalStatic violations from field declaration at to assignment in constructor.

Browse Source 
This makes it easier to identify the code that needs to be adjusted in order to resolve the violation.
This commit is contained in:
Maikel Steneker
2019-04-17 15:05:20 +02:00
parent 4ed549f0b2
commit cd465918b5
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/AssignmentToNonFinalStaticRule.java
View File

@ -33,16 +33,15 @@ public class AssignmentToNonFinalStaticRule extends AbstractJavaRule {
continue;
}
if (initializedInConstructor(entry.getValue())) {
addViolation(data, decl.getNode(), decl.getImage());
final Node location = initializedInConstructor(entry.getValue());
if (location != null) {
addViolation(data, location, decl.getImage());
}
}
return super.visit(node, data);
}
private boolean initializedInConstructor(List<NameOccurrence> usages) {
boolean initInConstructor = false;
private Node initializedInConstructor(List<NameOccurrence> usages) {
for (NameOccurrence occ : usages) {
// specifically omitting prefix and postfix operators as there are
// legitimate usages of these with static fields, e.g. typesafe enum pattern.
@ -50,12 +49,12 @@ public class AssignmentToNonFinalStaticRule extends AbstractJavaRule {
Node node = occ.getLocation();
Node constructor = node.getFirstParentOfType(ASTConstructorDeclaration.class);
if (constructor != null) {
initInConstructor = true;
return node;
}
}
}
return initInConstructor;
return null;
}
}