phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Iterative DotExpression evaluation instead of checking the first one

Browse Source
This commit is contained in:
Sergey
2017-03-02 17:47:56 -08:00
parent caf27adbc2
commit d12c1f7fe4
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java
View File

@ -392,7 +392,9 @@ public class VfUnescapeElRule extends AbstractVfRule {
}
if (child instanceof ASTDotExpression) {
return containsSafeFields((ASTDotExpression) child);
if (containsSafeFields((ASTDotExpression) child)) {
return true;
};
}
}

18
pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml
View File

@ -1,6 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
<test-data>
<test-code>
<description><![CDATA[
Safe escaped value in repeat
]]></description>
<expected-problems>0</expected-problems>
<code><![CDATA[
<apex:page>
<apex:outputPanel>
<input type="radio"
onclick="invokeDoSelectFormat('{!editFormat.recordType.Id}');">
</input>
</apex:outputPanel>
</apex:page>
]]></code>
<source-type>vf</source-type>
</test-code>
<test-code>
<description><![CDATA[
Safe escaped value in repeat