phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding logging

Browse Source 
Display error dialog in a thread safe way


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@1650 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Philippe Herlin
2003-03-30 20:46:21 +00:00
parent 0c3ec1ec39
commit d609e227bf
1 changed files with 12 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
pmd-eclipse/src/net/sourceforge/pmd/eclipse/PMDProcessor.java
View File

@ -11,12 +11,12 @@ import net.sourceforge.pmd.RuleContext;
import net.sourceforge.pmd.RuleSet;
import net.sourceforge.pmd.RuleSetFactory;
import net.sourceforge.pmd.RuleViolation;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.eclipse.core.resources.IFile;
import org.eclipse.core.resources.IMarker;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.swt.widgets.Display;
/**
* A class to process IFile resource against PMD
@ -25,6 +25,10 @@ import org.eclipse.swt.widgets.Display;
* @version $Revision$
*
* $Log$
* Revision 1.4 2003/03/30 20:46:21 phherlin
* Adding logging
* Display error dialog in a thread safe way
*
* Revision 1.3 2003/03/27 22:11:09 phherlin
* Fixing SWTException when PMD is processing a file with syntax error
* (Thanks to Chris Grindstaff)
@ -32,6 +36,7 @@ import org.eclipse.swt.widgets.Display;
*/
public class PMDProcessor {
private static final PMDProcessor SELF = new PMDProcessor();
private static final Log log = LogFactory.getLog("net.sourceforge.pmd.eclipse.PMDProcessor");
private PMD pmdEngine;
/**
@ -54,6 +59,7 @@ public class PMDProcessor {
* @param fTask indicate if a task marker should be created
*/
public void run(IFile file, boolean fTask) {
log.info("Processing file " + file.getName());
try {
Reader input = new InputStreamReader(file.getContents());
RuleContext context = new RuleContext();
@ -65,30 +71,14 @@ public class PMDProcessor {
updateMarkers(file, context, fTask);
} catch (CoreException e) {
openError(e, PMDConstants.MSGKEY_ERROR_CORE_EXCEPTION);
PMDPlugin.getDefault().showError(getMessage(PMDConstants.MSGKEY_ERROR_CORE_EXCEPTION), e);
} catch (PMDException e) {
openError(e, PMDConstants.MSGKEY_ERROR_PMD_EXCEPTION);
log.warn(getMessage(PMDConstants.MSGKEY_ERROR_PMD_EXCEPTION), e);
} finally {
log.info("Processing done");
}
}
/**
* Open an error dialog on the UI thread
* Avoid SWT exception when processor is called from a secondary thread
* Thanks to Chris Grindstaff
* @param exception the exception to display
* @param messageKey the key of the message to display
*/
private void openError(final Exception exception, final String messageKey) {
Display.getDefault().syncExec(new Runnable() {
public void run() {
MessageDialog.openError(
null,
getMessage(PMDConstants.MSGKEY_ERROR_TITLE),
getMessage(messageKey) + exception.toString());
}
});
}
/**
* Update markers list for the specified file
* @param file the file for which markes are to be updated