Cleaned up

This commit is contained in:
Clément Fournier committed 2017-03-22 22:50:14 +01:00
1 parent be2f001c8c
commit d7555debd5
1 file changed
+4 -5
@@ -19,7 +19,7 @@ import net.sourceforge.pmd.lang.java.typeresolution.TypeHelper;
import net.sourceforge.pmd.lang.symboltable.NameOccurrence;
public class UseStringBufferForStringAppendsRule extends AbstractJavaRule {
@Override
public Object visit(ASTVariableDeclaratorId node, Object data) {
if (!TypeHelper.isA(node, String.class) || node.isArray()) {
@@ -46,13 +46,12 @@ public class UseStringBufferForStringAppendsRule extends AbstractJavaRule {
continue;
}
ASTConditionalExpression conditional = name.getFirstParentOfType(ASTConditionalExpression.class);
if (conditional != null
&& (name.jjtGetParent().jjtGetParent().jjtGetParent() == conditional
|| name.jjtGetParent().jjtGetParent().jjtGetParent().jjtGetParent() == conditional)
Node thirdParent = name.jjtGetParent().jjtGetParent().jjtGetParent();
if (conditional != null && (thirdParent == conditional || thirdParent.jjtGetParent() == conditional)
&& conditional.getFirstParentOfType(ASTStatementExpression.class) == statement) {
// is used in ternary as only option (not appended to other
// string)
continue;
}
if (statement.jjtGetNumChildren() > 0 && statement.jjtGetChild(0) instanceof ASTPrimaryExpression) {