[java] InvalidLogMessageFormat false-positive for a lambda argument

Fixes #2255

This is actually only a workaround - lambda parameters are ignored now.

docs/pages/release_notes.md

@@ -23,6 +23,7 @@ For the changes, see [PMD Designer Changelog](https://github.com/pmd/pmd-designe
 
 *   java-errorprone
     *   [#2250](https://github.com/pmd/pmd/issues/2250): \[java] InvalidLogMessageFormat flags logging calls using a slf4j-Marker
+    *   [#2255](https://github.com/pmd/pmd/issues/2255): \[java] InvalidLogMessageFormat false-positive for a lambda argument
 
 ### API Changes
 

pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/InvalidLogMessageFormatRule.java

@@ -158,11 +158,32 @@ public class InvalidLogMessageFormatRule extends AbstractJavaRule {
         int lastIndex = params.size() - 1;
         ASTPrimaryExpression last = params.get(lastIndex).getFirstDescendantOfType(ASTPrimaryExpression.class);
 
-        if (isNewThrowable(last) || hasTypeThrowable(last) || isReferencingThrowable(last)) {
+        if (isNewThrowable(last) || hasTypeThrowable(last) || isReferencingThrowable(last) || isLambdaParameter(last)) {
             params.remove(lastIndex);
         }
     }
 
+    private boolean isLambdaParameter(ASTPrimaryExpression last) {
+        String varName = null;
+        ASTPrimaryPrefix prefix = last.getFirstChildOfType(ASTPrimaryPrefix.class);
+        if (prefix != null) {
+            ASTName name = prefix.getFirstChildOfType(ASTName.class);
+            if (name != null) {
+                varName = name.getImage();
+            }
+        }
+        for (NameDeclaration decl : prefix.getScope().getDeclarations().keySet()) {
+            if (decl.getName().equals(varName)) {
+                if (decl.getNode().getParent() instanceof ASTLambdaExpression) {
+                    // If the last parameter is a lambda parameter, then we also ignore it - regardless of the type.
+                    // This is actually a workaround, since type resolution doesn't resolve the types of lambda parameters.
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
+
     private String getExpectedMessage(final List<ASTExpression> params, final int expectedArguments) {
         return " expected " + expectedArguments + (expectedArguments > 1 ? " arguments " : " argument ") + "but have "
                 + params.size();

pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/InvalidLogMessageFormat.xml

@@ -785,7 +785,7 @@ public class InvalidLogMessageFormatTest {
     </test-code>
 
     <test-code>
-        <description>ignore slf4j-Markers when detecting the number of arguments</description>
+        <description>ignore slf4j-Markers when detecting the number of arguments #2250</description>
         <expected-problems>2</expected-problems>
         <expected-linenumbers>11,17</expected-linenumbers>
         <code><![CDATA[
@@ -807,6 +807,30 @@ public class InvalidLogMessageFormatTest {
         final var otherMarker = MarkerFactory.getMarker("OTHER_MARKER");
         logger.warn(otherMarker, "foo"); // gets flagged as we can't statically determine the type of the "otherMarker" variable
     }
+}
+        ]]></code>
+    </test-code>
+
+    <test-code>
+        <description>[java] InvalidLogMessageFormat false-positive for a lambda argument #2255</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class InvalidLogMessageFormatTest {
+    private static final Logger LOGGER = LoggerFactory.getLogger(InvalidLogMessageFormatTest.class);
+
+    private InvalidLogMessageFormatTest() {
+    }
+
+    public static void main(String[] args) {
+        foo(exception -> LOGGER.error("Foo", exception));
+    }
+
+    private static void foo(Consumer<Throwable> consumer) {
+        consumer.accept(new IllegalArgumentException());
+    }
 }
         ]]></code>
     </test-code>