Merge branch 'master' into doc-supported-languages

2022-10-06 13:03:52 -03:00
commit e22a77699e
@@ -6866,7 +6866,8 @@
      "avatar_url": "https://avatars.githubusercontent.com/u/109954313?v=4",
      "profile": "https://github.com/LynnBroe",
      "contributions": [
-        "code"
+        "code",
+        "bug"
      ]
    },
    {
@@ -19,7 +19,7 @@ Please provide the rule name and a link to the rule documentation:

 **Code Sample demonstrating the issue:**

-```
+```java

 ```

@@ -19,7 +19,7 @@ Please provide the rule name and a link to the rule documentation:

 **Code Sample demonstrating the issue:**

-```
+```java

 ```

@@ -17,7 +17,7 @@ assignees: ''
 **Code Sample:** This should include code, that should be flagged by the rule. If possible, the "correct" code
 according to this new rule should also be demonstrated.

-```
+```java

 ```

@@ -25,7 +25,7 @@ A clear and concise description of what the bug is.

 **Code Sample demonstrating the issue:**

-```
+```java

 ```

@@ -429,7 +429,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
  </tr>
  <tr>
    <td align="center"><a href="https://github.com/Lukebray"><img src="https://avatars.githubusercontent.com/u/39488446?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Lukebray</b></sub></a><br /><a href="https://github.com/pmd/pmd/issues?q=author%3ALukebray" title="Bug reports">🐛</a></td>
-    <td align="center"><a href="https://github.com/LynnBroe"><img src="https://avatars.githubusercontent.com/u/109954313?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Lynn</b></sub></a><br /><a href="https://github.com/pmd/pmd/commits?author=LynnBroe" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/LynnBroe"><img src="https://avatars.githubusercontent.com/u/109954313?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Lynn</b></sub></a><br /><a href="https://github.com/pmd/pmd/commits?author=LynnBroe" title="Code">💻</a> <a href="https://github.com/pmd/pmd/issues?q=author%3ALynnBroe" title="Bug reports">🐛</a></td>
    <td align="center"><a href="https://github.com/lgoldstein"><img src="https://avatars.githubusercontent.com/u/1436205?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Lyor Goldstein</b></sub></a><br /><a href="https://github.com/pmd/pmd/issues?q=author%3Algoldstein" title="Bug reports">🐛</a></td>
    <td align="center"><a href="https://mcmics.jnet24.de/"><img src="https://avatars.githubusercontent.com/u/4604206?v=4?s=100" width="100px;" alt=""/><br /><sub><b>MCMicS</b></sub></a><br /><a href="https://github.com/pmd/pmd/issues?q=author%3AMCMicS" title="Bug reports">🐛</a></td>
    <td align="center"><a href="https://github.com/Macarse"><img src="https://avatars.githubusercontent.com/u/24915?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Macarse</b></sub></a><br /><a href="https://github.com/pmd/pmd/issues?q=author%3AMacarse" title="Bug reports">🐛</a></td>
@@ -17,10 +17,13 @@ This is a {{ site.pmd.release_type }} release.
 ### Fixed Issues
 * doc
    * [#4144](https://github.com/pmd/pmd/pull/4144) \[doc] Update docs to reflect supported languages
+* java-documentation
+    * [#4141](https://github.com/pmd/pmd/issues/4141): \[java] UncommentedEmptyConstructor FP when constructor annotated with @<!-- -->Autowired

 ### API Changes

 ### External Contributions
+* [#4142](https://github.com/pmd/pmd/pull/4142): \[java] fix #4141 Update UncommentedEmptyConstructor - ignore @<!-- -->Autowired annotations - [Lynn](https://github.com/LynnBroe) (@LynnBroe)

 {% endtocmaker %}

@@ -102,7 +102,10 @@ and unintentional empty constructors.
                        [@containsComment = false()]
                        [not(BlockStatement)]
                        [$ignoreExplicitConstructorInvocation = true() or not(ExplicitConstructorInvocation)]
-                        [not(../Annotation/MarkerAnnotation/Name[pmd-java:typeIs('javax.inject.Inject')])]
+                        [not(../Annotation/MarkerAnnotation/Name[
+                                                                pmd-java:typeIs('javax.inject.Inject')
+                                                             or pmd-java:typeIs('org.springframework.beans.factory.annotation.Autowired')
+                                                                ])]
 ]]>
                </value>
            </property>
@@ -187,4 +187,30 @@ public class MyClass {
 }
        ]]></code>
    </test-code>
+
+    <test-code>
+        <description>#4141 UncommentedEmptyConstructor FP when annotated constructor with @Autowired</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import org.springframework.beans.factory.annotation.Autowired;
+public class Bug {
+    @Autowired
+    public Bug() {
+    }
+}
+        ]]></code>
+    </test-code>
+
+    <test-code>
+        <description>#4141 UncommentedEmptyConstructor FP when annotated constructor with @Autowired</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class Bug {
+    @org.springframework.beans.factory.annotation.Autowired
+    public Bug() {
+    }
+}
+        ]]></code>
+    </test-code>
+
 </test-data>
@@ -30,6 +30,7 @@
                    <delimiters>
                        <delimiter>${*}</delimiter>
                    </delimiters>
+                    <escapeString>\</escapeString>
                </configuration>
            </plugin>
        </plugins>
@@ -67,7 +67,7 @@ The following types are considered valid: pom, jar, maven-plugin, ejb, war, ear,
          externalInfoUrl="${pmd.website.baseurl}/pmd_rules_pom_errorprone.html#projectversionasdependencyversion">
        <description>
 Using that expression in dependency declarations seems like a shortcut, but it can go wrong.
-By far the most common problem is the use of &#x24;{project.version} in a BOM or parent POM.
+By far the most common problem is the use of \${project.version} in a BOM or parent POM.
        </description>
        <priority>3</priority>
        <properties>
@@ -92,7 +92,7 @@ By far the most common problem is the use of &#x24;{project.version} in a BOM or
  ...
  <dependency>
    ...
-    <version>${project.version}</version>
+    <version>\${project.version}</version>
  </dependency>
 </project>
 ]]>