phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

issue-1701 fix bug to suppress false positive in useTryWithResources when close method have multiple arguments

Browse Source
This commit is contained in:
Rishabh Jain
2019-03-11 22:11:24 -04:00
parent e5ca9d71bf
commit e590f29da8
3 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/pages/pmd/rules/java/bestpractices.md
View File

@@ -1657,7 +1657,7 @@ preserved.
][
pmd-java:typeIs('java.lang.AutoCloseable')
or
../../PrimarySuffix/Arguments[@ArgumentCount = 1]//PrimaryPrefix[pmd-java:typeIs('java.lang.AutoCloseable')]
../../PrimarySuffix/Arguments//PrimaryPrefix[pmd-java:typeIs('java.lang.AutoCloseable')]
]]
```

2
pmd-java/src/main/resources/category/java/bestpractices.xml
View File

@@ -1546,7 +1546,7 @@ preserved.
][
pmd-java:typeIs('java.lang.AutoCloseable')
or
../../PrimarySuffix/Arguments[@ArgumentCount = 1]//PrimaryPrefix[pmd-java:typeIs('java.lang.AutoCloseable')]
../../PrimarySuffix/Arguments//PrimaryPrefix[pmd-java:typeIs('java.lang.AutoCloseable')]
]]
]]>
</value>

24
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UseTryWithResources.xml
View File

@@ -189,4 +189,28 @@ public class TryWithResources {
}
]]></code>
</test-code>
<test-code>
<description>Custom close methods with multiple arguments</description>
<rule-property name="closeMethods">myClose2,myClose</rule-property>
<expected-problems>1</expected-problems>
<expected-linenumbers>6</expected-linenumbers>
<code><![CDATA[
import java.io.*;
public class TryWithResources {
public void run() {
InputStream in = null, in2 = null;
try {
in = openInputStream();
in2 = openInputStream();
int i = in.read(), j = in2.read();
} catch (IOException e) {
e.printStackTrace();
} finally {
myClose(in, in2);
}
}
}
]]></code>
</test-code>
</test-data>