phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes #2157

Browse Source 
System.exit() and its equivalents should be allowed in static main() methods, added check for Runtime.getRuntime().halt()
This commit is contained in:
Vitaly Polonetsky
2020-09-24 18:52:59 -07:00
parent f1e9a23b01
commit e8b95f1a21
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pmd-java/src/main/resources/category/java/errorprone.xml
View File

@@ -1304,7 +1304,7 @@ public class GCCall {
externalInfoUrl="${pmd.website.baseurl}/pmd_rules_java_errorprone.html#donotcallsystemexit">
<description>
Web applications should not call System.exit(), since only the web container or the
application server should stop the JVM. This rule also checks for the equivalent call Runtime.getRuntime().exit().
application server should stop the JVM. This rule also checks for the equivalent calls Runtime.getRuntime().exit() and Runtime.getRuntime().halt().
</description>
<priority>3</priority>
<properties>
@@ -1315,8 +1315,8 @@ application server should stop the JVM. This rule also checks for the equivalent
//Name[
starts-with(@Image,'System.exit')
or
(starts-with(@Image,'Runtime.getRuntime') and ../../PrimarySuffix[ends-with(@Image,'exit')])
]
(starts-with(@Image,'Runtime.getRuntime') and ../../PrimarySuffix[ends-with(@Image,'exit') or ends-with(@Image,'halt')])
][not(ancestor::MethodDeclaration[1][@Name="main" and @Static = true()])]
]]>
</value>
</property>