Checkstyle fixes

This commit is contained in:
oowekyala
2017-05-22 19:16:42 +02:00
parent cad0697798
commit ea2523489a
6 changed files with 28 additions and 18 deletions

View File

@ -4,6 +4,17 @@
package net.sourceforge.pmd;
import java.io.File;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
import net.sourceforge.pmd.benchmark.Benchmark;
import net.sourceforge.pmd.benchmark.Benchmarker;
import net.sourceforge.pmd.cache.ChecksumAware;
@ -16,11 +27,6 @@ import net.sourceforge.pmd.util.StringUtil;
import net.sourceforge.pmd.util.filter.Filter;
import net.sourceforge.pmd.util.filter.Filters;
import java.io.File;
import java.util.*;
import java.util.logging.Level;
import java.util.logging.Logger;
/**
* This class represents a collection of rules along with some optional filter
* patterns that can preclude their application on specific files.
@ -361,7 +367,7 @@ public class RuleSet implements ChecksumAware {
throw new IllegalArgumentException(MISSING_RULE);
}
for (final Iterator<Rule> it = rules.iterator(); it.hasNext(); ) {
for (final Iterator<Rule> it = rules.iterator(); it.hasNext();) {
final Rule r = it.next();
if (r.getName().equals(rule.getName()) && r.getLanguage() == rule.getLanguage()) {
it.remove();

View File

@ -51,7 +51,7 @@ public abstract class AbstractLanguageVersionHandler implements LanguageVersionH
}
@Override
public VisitorStarter getMetricsVisitorFacade(ClassLoader classLoader){
public VisitorStarter getMetricsVisitorFacade(ClassLoader classLoader) {
return VisitorStarter.DUMMY;
}

View File

@ -4,16 +4,20 @@
package net.sourceforge.pmd.lang.rule;
import net.sourceforge.pmd.*;
import java.util.List;
import java.util.Map;
import java.util.Set;
import net.sourceforge.pmd.PropertyDescriptor;
import net.sourceforge.pmd.PropertySource;
import net.sourceforge.pmd.Rule;
import net.sourceforge.pmd.RuleContext;
import net.sourceforge.pmd.RulePriority;
import net.sourceforge.pmd.lang.Language;
import net.sourceforge.pmd.lang.LanguageVersion;
import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.ast.Node;
import java.util.List;
import java.util.Map;
import java.util.Set;
/**
* Base class for Rule implementations which delegate to another Rule instance.
*/

View File

@ -4,6 +4,9 @@
package net.sourceforge.pmd.lang.rule;
import java.util.ArrayList;
import java.util.List;
import net.sourceforge.pmd.AbstractPropertySource;
import net.sourceforge.pmd.Rule;
import net.sourceforge.pmd.RuleContext;
@ -13,9 +16,6 @@ import net.sourceforge.pmd.lang.LanguageVersion;
import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.ast.Node;
import java.util.ArrayList;
import java.util.List;
/**
* Basic abstract implementation of all parser-independent methods of the Rule
* interface.

View File

@ -98,7 +98,7 @@ public abstract class AbstractJavaHandler extends AbstractLanguageVersionHandler
}
@Override
public VisitorStarter getMetricsVisitorFacade(final ClassLoader classLoader){
public VisitorStarter getMetricsVisitorFacade(final ClassLoader classLoader) {
return new VisitorStarter() {
@Override
public void start(Node rootNode) {

View File

@ -14,8 +14,8 @@ import net.sourceforge.pmd.lang.java.ast.JavaParserVisitorAdapter;
*/
public class MetricsVisitorFacade extends JavaParserVisitorAdapter {
public void initializeWith(ClassLoader classLoader, ASTCompilationUnit rootNode){
public void initializeWith(ClassLoader classLoader, ASTCompilationUnit rootNode) {
System.err.println("Metrics init!");
}
}