phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'bug-1464'

Browse Source
This commit is contained in:
Andreas Dangel
2016-02-28 15:13:10 +01:00
parent 1402e9320b 573186be69
commit ee131a3553
3 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-java/src/main/resources/rulesets/java/unnecessary.xml
View File

@ -70,7 +70,9 @@ tagged as such.
<value>
<![CDATA[
//ClassOrInterfaceDeclaration[@Final='true' and @Interface='false']
/ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration/MethodDeclaration[@Final='true']
/ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration
[count(./Annotation/MarkerAnnotation/Name[@Image='SafeVarargs' or @Image='java.lang.SafeVarargs']) = 0]
/MethodDeclaration[@Final='true']
]]>
</value>
</property>

19
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UnnecessaryFinalModifier.xml
View File

@ -97,4 +97,23 @@ public final class Foo {
}
]]></code>
</test-code>
<test-code>
<description>#1464 UnnecessaryFinalModifier false positive on a @SafeVarargs method</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public final class InboxContents<T> {
@SafeVarargs
public final InboxContents<T> conflateWith(T... values) { // false positive
return conflateWith(ImmutableList.copyOf(values));
}
}
public final class InboxContents2 {
@java.lang.SafeVarargs
public final InboxContents conflateWith(String... values) {
return conflateWith(ImmutableList.copyOf(values));
}
}
]]></code>
</test-code>
</test-data>