phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Renaming rules to security, fixing leading whitespaces

Browse Source
This commit is contained in:
Sergey 2017-02-16 13:08:52 -08:00 committed by Juan Martín Sotuyo Dodero
parent 1218cd5c5b
commit f799cf2e5b
7 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-visualforce/etc/grammar/VfParser.jjt
View File

@ -152,8 +152,8 @@ PARSER_END(VfParser)
<AttrValueState> TOKEN :
{
<SINGLE_QUOTE: "'"> : AttrValueBetweenSingleQuotesState
| <DOUBLE_QUOTE: "\""> : AttrValueBetweenDoubleQuotesState
<SINGLE_QUOTE: (<WHITESPACES>)? "'"> : AttrValueBetweenSingleQuotesState
| <DOUBLE_QUOTE: (<WHITESPACES>)? "\"">: AttrValueBetweenDoubleQuotesState
| <NO_QUOTE_NO_WHITESPACE: ~["\"","'"," "] > { input_stream.backup(1);} : AttrValueNoQuotesState
| <IN_ATTR_WHITESPACE: [" "] > : InTagState //support for empty attributes
}

2
pmd-visualforce/pom.xml
View File

@ -2,7 +2,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>pmd-visualforce</artifactId>
<name>PMD VISUALFORCE</name>
<name>PMD Visualforce</name>
<parent>
<groupId>net.sourceforge.pmd</groupId>

2
pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/basic/VfUnescapeElRule.java → pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java
View File

@ -2,7 +2,7 @@
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.vf.rule.basic;
package net.sourceforge.pmd.lang.vf.rule.security;
import java.util.List;
import java.util.regex.Pattern;

2
pmd-visualforce/src/main/resources/rulesets/vf/rulesets.properties
View File

@ -2,4 +2,4 @@
# BSD-style license; for more info see http://pmd.sourceforge.net/license.html
#
rulesets.filenames=rulesets/vf/basic.xml
rulesets.filenames=rulesets/vf/security.xml

8
pmd-visualforce/src/main/resources/rulesets/vf/basic.xml → pmd-visualforce/src/main/resources/rulesets/vf/security.xml
View File

@ -8,10 +8,10 @@
<description>Rules concerning basic VF guidelines.</description>
<rule name="VfUnescapeEl" since="3.7"
message="Avoid unescaping of user controlled content in EL such as ''{0}''"
class="net.sourceforge.pmd.lang.vf.rule.basic.VfUnescapeElRule"
externalInfoUrl="${pmd.website.baseurl}/rules/vf/basic.html#VfUnescapeElRule">
<description><![CDATA[Avoid unescaping of user controlled content in EL to avoid XSS. ]]>
message="Avoid unescaped user controlled content in EL"
class="net.sourceforge.pmd.lang.vf.rule.security.VfUnescapeElRule"
externalInfoUrl="${pmd.website.baseurl}/rules/vf/security.html#VfUnescapeElRule">
<description><![CDATA[Avoid unescaped user controlled content in EL as it results in XSS. ]]>
</description>
<priority>3</priority>
<example>

6
pmd-visualforce/src/test/java/net/sourceforge/pmd/lang/vf/rule/basic/BasicRulesTest.java → pmd-visualforce/src/test/java/net/sourceforge/pmd/lang/vf/rule/security/SecurityRulesTest.java
View File

@ -2,13 +2,13 @@
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.vf.rule.basic;
package net.sourceforge.pmd.lang.vf.rule.security;
import net.sourceforge.pmd.testframework.SimpleAggregatorTst;
public class BasicRulesTest extends SimpleAggregatorTst {
public class SecurityRulesTest extends SimpleAggregatorTst {
private static final String RULESET = "vf-basic";
private static final String RULESET = "vf-security";
@Override
public void setUp() {

2
pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/basic/xml/VfUnescapeEl.xml → pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml
View File

@ -59,6 +59,6 @@ No XSS via EL via param binding
]]></code>
<source-type>vf</source-type>
</test-code>
</test-code>
</test-data>