phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract Pattern constant from parse method

Browse Source
This commit is contained in:
Clément Fournier
2018-01-20 01:53:23 +01:00
parent 6e461f09d7
commit f8ca4a75d3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaQualifiedName.java
View File

@ -76,6 +76,7 @@ public final class JavaQualifiedName implements QualifiedName {
// maps class names to the names of their local classes, to the count of local classes with the same name
private static final Map<JavaQualifiedName, Map<String, Integer>> LOCAL_INDICES = new WeakHashMap<>();
private static final Pattern LOCAL_INDEX_PATTERN = Pattern.compile("(\\d+)(\\w+)");
private String[] packages = null; // unnamed package
private String[] classes = new String[1];
@ -292,10 +293,9 @@ public final class JavaQualifiedName implements QualifiedName {
qname.classes = matcher.group(CLASSES_GROUP_INDEX).split("\\$");
qname.localIndices = new int[qname.classes.length];
Pattern localIndexPattern = Pattern.compile("(\\d+)(\\w+)");
for (int i = 0; i < qname.classes.length; i++) {
Matcher localIndexMatcher = localIndexPattern.matcher(qname.classes[i]);
Matcher localIndexMatcher = LOCAL_INDEX_PATTERN.matcher(qname.classes[i]);
if (localIndexMatcher.matches()) {
qname.localIndices[i] = Integer.parseInt(localIndexMatcher.group(1));
qname.classes[i] = localIndexMatcher.group(2);