2952 Commits

Author SHA1 Message Date
Philippe Herlin
13cb49e90f Releasing v2.2.0
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3184 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-23 16:05:01 +00:00
Philippe Herlin
82a389d157 Upgrade to PMD 2.1
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3183 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-23 16:04:44 +00:00
Miguel Griffa
3d6c544b83 added test case for rule that seems to work but an NPE stack trace is seen...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3182 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-21 14:35:51 +00:00
Tom Copeland
b377657a31 some very minor refactoring
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3181 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 21:47:57 +00:00
Miguel Griffa
340fe24387 little bit hard to find:
include rulesets properties in jar built with maven


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3180 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 21:10:11 +00:00
Miguel Griffa
03f9dad0f4 implementd RFE 1096770 - Additional String Concatenation Warnings
Thanks george


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3179 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 15:59:24 +00:00
Miguel Griffa
5a87a9cde2 new utility method isAllocation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3178 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 15:26:57 +00:00
Miguel Griffa
83b3f5d47b uncommented test for bug 996007 which seems to be passing
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3177 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 14:58:30 +00:00
Miguel Griffa
85b10a9a60 added test9 (not refined yet)
and test10 to ensure bug 1105633 ( False +: JUnit testcases could have fail() instead of assert) is fixed


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3176 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 14:47:46 +00:00
Tom Copeland
c27af6641f Test gardening
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3175 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 14:22:15 +00:00
Tom Copeland
4c1e580f0d Just commenting this out to make sure all the other tests pass....
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3174 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-20 01:24:46 +00:00
Miguel Griffa
8c64bb3b88 RFE added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3173 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 19:33:42 +00:00
Tom Copeland
c3a3f0be58 Applied patch 1105426: Add AnyLanguage with some default tokenization. Thanks to John Heintz for the nice patch!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3172 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 18:44:26 +00:00
Miguel Griffa
9381bc3d10 updated doc for
[ 1031950 ] Support For Nested Ruleset Tags By The PMD Ant Task


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3171 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 18:42:42 +00:00
Miguel Griffa
524d865666 very simple test for
[ 1031950 ] Support For Nested Ruleset Tags By The PMD Ant Task


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3170 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 18:36:59 +00:00
Miguel Griffa
ade3938eaf initial implementation for nested rulesets in the ant task in the form of
<ruleset>
documentation and tests following

[ 1031950 ] Support For Nested Ruleset Tags By The PMD Ant Task


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3169 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 18:35:45 +00:00
Miguel Griffa
819bae9620 fixed bug #996007
I'll add more test now since I'm not quite convinced with current results


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3168 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 15:35:54 +00:00
Miguel Griffa
4463990e4d more simplifications of impl
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3167 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 15:19:49 +00:00
Miguel Griffa
6ab8ef3f55 refactored to use getFirstASTNameImage
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3166 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 15:10:00 +00:00
Miguel Griffa
d35ec1387a new utility method added: getFirstASTNameImage
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3165 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-19 15:08:32 +00:00
Tom Copeland
66a4d4214e Fixed typo; Miguel, I think this is why this test passed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3164 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 20:46:33 +00:00
Tom Copeland
dbcbaa0794 Bump Eric Olander to the top of the list. The way I've been adding credits is sort of like a stack - so that when anyone does something, they get bumped to the top of the list. So as people are inactive, they sort of filter to the bottom. For some reason I like this :-)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3163 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 16:37:18 +00:00
Tom Copeland
6ab805cebf Oops, finished up a little refactoring
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3162 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 16:32:15 +00:00
Miguel Griffa
a8e9c5632f added clover and simian reports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3161 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 16:29:53 +00:00
Miguel Griffa
f390fd5e71 test case for patch [ 1056855 ] non-final static fields in constructors
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3160 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 15:42:47 +00:00
Miguel Griffa
4f1eb6a456 applied patch [ 1056855 ] non-final static fields in constructors
from Eric Olander


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3159 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 15:42:10 +00:00
Miguel Griffa
7bbf2e3de8 added test case for bug #996007
which surprisingly is not failing


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3158 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 14:44:23 +00:00
Tom Copeland
c079f50d33 Moved resultTypeIsArray onto ASTResultType; this seems to be a good home for it. Miguel, this might be a good strategy for placing these utility methods; if there's a node type that seems logical, go ahead and put it there. But if not, what you're doing so far is fine too; it's good that you're identifying possible utility methods. Maybe some day we can look over the current rules and see if any of them can use these methods, too...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3157 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 14:28:11 +00:00
Tom Copeland
5ae3caed4b Adding a few edge cases, looking good!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3156 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 14:18:51 +00:00
Tom Copeland
96f93cfe33 Minor test tweaks
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3155 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 14:16:16 +00:00
Tom Copeland
6e308ff4a6 Updated Miguel's entry to its proper position on the credits page - to the ranks of the committers. Good times!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3154 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-18 14:13:54 +00:00
Miguel Griffa
f905d39b14 imports clean
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3153 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 20:19:46 +00:00
Miguel Griffa
e3724ea062 initial import of ArrayIsStoredDirectly sun security guidelines rule
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3152 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 20:18:24 +00:00
Miguel Griffa
3d869fda25 new simple optimization rule:
AvoidInstantiatingObjectsInLoops


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3151 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 20:03:32 +00:00
Miguel Griffa
e6358047fe new utility method added:
containsChildOfType


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3150 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 18:57:07 +00:00
Miguel Griffa
6ecffd1e51 initial rule for sun security guidelines
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3149 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 16:39:34 +00:00
Tom Copeland
bea46df241 Import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3148 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 16:04:45 +00:00
Tom Copeland
4df0978f5d Some minor test gardening
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3147 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 16:01:40 +00:00
Miguel Griffa
8074c5ae6d moved addViolation to AbstractRule so it can be used from other rulesets
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3146 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 15:21:16 +00:00
Miguel Griffa
c33138d712 added addViolation method to simplify rule programming
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3145 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-17 15:20:42 +00:00
Philippe Herlin
c6f1e919ad Upgrade to PMD 2.1: take into account new rules attributes symboltable and dfa
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3144 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-16 22:53:03 +00:00
Philippe Herlin
6c5412400b Upgrade to PMD 2.1: add new packaged rulesets
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3143 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-16 22:52:17 +00:00
Tom Copeland
a0a833e30f A slight change to the unit tests - now they load the rule via the XML file. This ensures that the XML file is readable by PMD and that nothing gets skipped. It takes a little longer to run since the RuleSetFactory has to load and parse the whole ruleset rather than just instantiating the rule, but I think it's worth it for the safety...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3142 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-14 20:28:54 +00:00
Miguel Griffa
59a1661e42 a possible solution for feature request 1083212 (Designer could show the AST in XML)
http://sourceforge.net/tracker/index.php?func=detail&aid=1083212&group_id=56262&atid=479924


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3141 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-14 18:20:23 +00:00
Miguel Griffa
205cb80b7a simple test for asXml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3140 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-14 18:18:49 +00:00
Miguel Griffa
03f76836f4 added asXml method that retrives a string representation of the tree with the current node as the root
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3139 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-14 18:16:48 +00:00
Miguel Griffa
645f722676 I thing I have fixed
[ 1038229 ] Missed hit: Unused private methods called only by themselves


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3138 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-14 15:10:41 +00:00
Miguel Griffa
e54099fe32 better name for section
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3137 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-13 19:09:23 +00:00
Miguel Griffa
3bf8ea664d initial index for rules
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3136 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-13 19:08:35 +00:00
Miguel Griffa
7b6e9cd887 very initial work for generating an index page for rules in site.
maven stuff seems ok, template needs a lot of work to go public


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3135 51baf565-9d33-0410-a72c-fc3788e3496d
2005-01-13 17:13:31 +00:00