1ecae7ae3e
AvoidLiteralsInIfCondition rule ignored in dogfood rulesets
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6892 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 23:41:12 +00:00
e185ff8215
CallSuperLast rule now also checks for finish() redefinitions
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6890 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 23:05:14 +00:00
e606357121
new rule AvoidLiteralsInIfCondition added to controversial ruleset
...
Patch contributed by Nadhamuni Kothapalle
https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591627&group_id=56262
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6889 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-22 23:02:16 +00:00
b4d2fa0e31
Updated Javadoc (a process reminder for myself)
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6887 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-10 03:14:13 +00:00
ef36aee425
Misc for-loop conversions
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6886 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-09 22:46:03 +00:00
53dd793369
Restored ability add new variables for XPath rules, the dialog is raw but will be tweaked. Need to modify the Rule interface in PMD property to be able to drop them...upcoming.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6885 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-09 22:43:12 +00:00
e34b601585
udpating PMD too - now it is 4.2.5 so changing version.
...
a missing part of previous Marek's patch for layer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6882 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-05 05:01:35 +00:00
4397150448
updating to a new version - patch contributed by Marek Slama (marek.slama at sun dot com)
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6881 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-05 04:16:06 +00:00
1b2aabc93b
Fixed bug 2645268 - ClassCastException in UselessOperationOnImmutable.getDeclaration
...
Problem was due to incorrect assumption about AST structure, when Annotations are present on a local declaration.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6880 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-01 09:58:09 +00:00
1254933e74
misc loop conversion
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6878 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-27 16:17:05 +00:00
5c98ea43c1
Adjust field colouring to reflect overridden property values, added missing XPath version field.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6877 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-27 16:11:56 +00:00
491a6e34e8
Bugfix for disappearing rule after adding new one.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6876 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-25 02:25:12 +00:00
837c81cfb4
Added new panel to the preference page for XPath settings. Relevant tabs show "-----" when disabled now.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6875 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-24 00:17:17 +00:00
6d0799ad6f
Fixed bug 2606609 - False "UnusedImports" positive in package-info.java
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6873 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 17:28:29 +00:00
af96d35b5a
wrong test case for Bug 2606609 : False "UnusedImports" positive in package-info.java
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6872 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 17:19:26 +00:00
beb9f12d23
Loop conversions, extURL validation, minor ui cleanup
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6871 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:41:58 +00:00
37b2f9a3ab
typos
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6870 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:28:59 +00:00
ba9ee69e86
Deprecation tags, for-loop and StringBuffer conversions
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6869 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:22:59 +00:00
b9ded04e51
For loop and StringBuffer->StringBuilder conversions
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6868 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:07:21 +00:00
461cf80bfd
pmd.jar updated to snapshot version 6861
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6867 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 19:29:25 +00:00
c560315d0a
Refactored packages, additional fields & panels, numerous bugfixes & improvements. Almost ready for prime time. Requires latest PMD 5.0 jar.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6866 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 09:28:09 +00:00
a8718ea86b
Text cleanup: removed leading spaces from descriptions & code, formatted code examples consistently.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6865 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 09:16:08 +00:00
420ab1b35b
Text cleanup: removed leading spaces from descriptions & code, formatted code examples consistently, zapped numerous typos.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6864 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 09:10:59 +00:00
fef4a4e39b
Text cleanup: removed leading spaces from descriptions & code, formatted code examples consistently, zapped numerous typos.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6863 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 08:58:44 +00:00
60de38f2af
Text cleanup: removed leading spaces from descriptions & code, formatted code examples consistently, zapped numerous typos.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6862 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 08:40:06 +00:00
bf4843d9bc
A bugfix and new general utility functions used by the Eclipse plugin.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6861 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 07:45:52 +00:00
50e9be7153
Merging with xlv fix
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6860 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-20 11:21:47 +00:00
c982826e41
test case failed as '}' was missing
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6859 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-20 02:46:22 +00:00
eb9b8ad142
Test case and fix for bug [2317099 ] false + in SimplifyConditional.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6857 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-19 22:45:26 +00:00
2595a6966a
Oops, small typo in a test file
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6854 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-18 22:57:41 +00:00
5baf82945f
Reproduced bug 2614040 : false + if a += assignment operator is used insidea method call
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6853 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-18 22:57:06 +00:00
66b9d1cbd0
merged
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6852 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-18 22:56:30 +00:00
901e64073a
Issue does not reproduce in trunk... I'll check if the fix can be backport to 4.2.X branch
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6851 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-17 00:49:21 +00:00
fc3fc3fcba
Reproducing bug False 2606609: 'UnusedImports' positive in package-info.java
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6850 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-17 00:48:30 +00:00
4a385f8ace
AvoidCatchingGenericException excluded from dogfood ruleset
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6846 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-12 20:17:37 +00:00
42a4eeb7e5
new rules added, keeping rulesets and rules sorted
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6845 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-12 20:07:19 +00:00
b56716e52a
New rule in strictexceptions : AvoidCatchingGenericException
...
patch submitted by Nadhamuni Kothapalle
https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2591604&group_id=56262
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6844 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-12 19:54:36 +00:00
596606d56f
android ruleset was not in changelog
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6833 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 01:19:53 +00:00
595c976cdb
note for Fixed bug 2027626 - False + : AvoidFinalLocalVariable
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6827 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-09 00:43:23 +00:00
5d323e8d2d
Fix for bug 2027626: False + : AvoidFinalLocalVariable
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6826 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 22:05:01 +00:00
afdc81bb43
Adding test case to reproduce bug 2027626:False + : AvoidFinalLocalVariable
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6825 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 22:03:43 +00:00
0139b91533
2009 added to copyright
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6822 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 21:34:24 +00:00
744e8ed6fd
Fixed bug 2142986 - UselessOverridingMethod doesn't consider annotations
...
new property 'ignoreAnnotations' to get the old behavior
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6819 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-08 19:45:22 +00:00
dbbd405825
merge from 4.2.x branch:
...
Bug fixing 1609038 - Xslt report generators break if path contains 'java'.
As suggested by bug reporter i switch call to 'translate' and call to 'substring-before'.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6817 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-05 20:09:39 +00:00
60efdb026d
new rule in strictexception: AvoidThrowingNewInstanceOfSameException
...
contributed by George Thomas:
https://sourceforge.net/tracker/?func=detail&atid=479923&aid=2566369&group_id=56262
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6815 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-05 03:40:38 +00:00
bdffdc9db8
CallSuperFirst android rule now accepts logging before call to super()
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6813 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-04 23:58:40 +00:00
307997cdc3
Adding testcase for bug '2225474 - VariableNamingConventions does not work with nonprimitives' however as the underlying rule has been completly rewritten since, this case has been handed properly (or so it seems)... So nothing to fix here.
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6808 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-28 21:10:09 +00:00
ec72c6b30b
oops, forgot to commit the new ruleset
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6806 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-28 01:35:19 +00:00
35ae8858e6
ruleset paths updated to new directory structure, warnings for moved rules
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6805 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-28 01:20:30 +00:00
6ce2ec41e5
new ruleset for Android platform
...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6804 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-28 01:04:22 +00:00
