2712 Commits

Author SHA1 Message Date
Andreas Dangel
30b6f14f85 Merge branch 'pr-2284'
[java] MisplacedNullCheck - fix false positive
2020-02-29 10:22:55 +01:00
Andreas Dangel
59e4be3648 Update gitignore
files generated by eclipse m2e plugin and pmd plugin
2020-02-20 11:29:10 +01:00
Andreas Dangel
4ce85c4656 [java] Fix deprecated usage of ArgumentCount/ParameterCount in rules 2020-02-16 14:41:37 +01:00
Andreas Dangel
80cba026c2 [java] Deprecate getArgumentCount()/getParameterCount()
* ASTArguments#getArgumentCount()
* ASTFormalParameters#getParameterCount()

Refs #2271
2020-02-16 13:12:28 +01:00
Andreas Dangel
7fb09deb3d Merge branch 'pr-2263'
[java] Fix InvalidLogMessageFormat false-positive with lambda arguments
2020-02-16 12:06:12 +01:00
Andreas Dangel
cb50a7af58 Merge branch 'pr-2236'
[java] Don't use ClassNotFoundException to report unresolved classes
2020-02-16 12:03:44 +01:00
Andreas Dangel
92fa8231e7 Merge branch 'pr-2267'
[docs] Update docs about writing rules
2020-02-16 11:57:26 +01:00
Andreas Dangel
d06b01785a [java] Code formatting for properties in SingularFieldRule 2020-02-16 11:20:02 +01:00
Andreas Dangel
9e2368257f Merge branch 'pr-2241'
[core] Simplify metrics framework
2020-02-16 10:57:10 +01:00
Andreas Dangel
3dbbb8a935 [java] MisplacedNullCheck - fix new false positives
Also simplify the xpath expression.
2020-02-13 16:16:08 +01:00
Andreas Dangel
00c0d3a713 [java] MisplacedNullCheck - fix false positive
* Upgrade to XPath 2.0
* Extend test cases
* Report on variable that is being null check and
  improve violation message

Fixes #2242
2020-02-13 15:04:27 +01:00
Andreas Dangel
86ef30f26a [java] Remove unnecessary CDATAs in tests for MisplacedNullCheck 2020-02-13 13:51:39 +01:00
Andreas Dangel
d03f00fce3 Merge branch 'pr-2252' into issue-2242 2020-02-13 13:46:09 +01:00
Andreas Dangel
4cef149f45 Merge branch 'pr-2278'
[java] fix UnusedImports rule for ambiguous static on-demand imports
2020-02-13 11:15:34 +01:00
Andreas Dangel
1bba78cc65 [java] Remove unnecessary CDATA for UnusedImports tests 2020-02-13 11:12:44 +01:00
Clément Fournier
d61ec4c737 Deprecations for #2248 2020-02-12 14:39:01 +01:00
kris-scheibe
63fbfbd8c7 UnusedImports rule now matches regular static imports first and on-demand static imports after that 2020-02-10 23:20:08 +01:00
Andreas Dangel
48cd952feb Merge branch 'pr-2269'
[java] Improve TypeHelper resilience
2020-02-10 19:17:24 +01:00
Andreas Dangel
0c9e813ac4 [java] AppendCharacterWithChar: remove unnecessary CDATA sections
The CDATA sections for the descriptions of the test cases
are not necessary.
2020-02-10 18:58:09 +01:00
kris-scheibe
adbe5eb553 make AppendCharacterWithCharRule ignore String literals, which are part of an expression, such as in StringBuffer.append("X".repeat(5)); 2020-02-09 07:23:13 +01:00
Clément Fournier
5ba1823005 Improve fallback strategy of TypeHelper 2020-02-06 16:56:20 +01:00
Andreas Dangel
dd87753f1a [java] InvalidLogMessageFormat: add disabled false-negative test case 2020-01-31 16:07:57 +01:00
Andreas Dangel
e0e858d39e [java] InvalidLogMessageFormat false-positive for a lambda argument
Fixes #2255

This is actually only a workaround - lambda parameters are ignored now.
2020-01-30 21:14:25 +01:00
Andreas Dangel
cad1f40b02 Merge branch 'pr-2251'
[java] FP for InvalidLogMessageFormat when using slf4j-Markers

Fixes #2250
2020-01-26 19:57:20 +01:00
Piotrek Żygieło
47aa8807ca Second TC, with only reordered conditions 2020-01-25 18:04:40 +01:00
Piotrek Żygieło
87ce7e1040 Add test case for MisplacedNullCheck/#2242 2020-01-25 12:12:00 +01:00
Clément Fournier
d91e626a0b Format idents in java grammar 2020-01-25 10:59:57 +01:00
kris-scheibe
60cb037f80 FP for InvalidLogMessageFormat when using slf4j-Markers 2020-01-25 10:17:59 +01:00
Clément Fournier
d90d5d267c Remove trailing whitespace everywhere 2020-01-24 23:40:06 +01:00
Clément Fournier
58fa793e67 Fix indentation in poms
For some reason pmd-apex and pmd-apex-jorje
use 2 spaces while the rest use 4.
2020-01-24 23:17:26 +01:00
Clément Fournier
c27481f815 Trim trailing spaces in XML 2020-01-24 23:08:52 +01:00
Andreas Dangel
d994700617 [maven-release-plugin] prepare for next development iteration 2020-01-24 17:20:47 +01:00
Andreas Dangel
a28e9e22e5 [maven-release-plugin] prepare release pmd_releases/6.21.0 2020-01-24 17:20:38 +01:00
Andreas Dangel
024fd7bd85 Merge branch 'pr-2244'
[core] Deprecate CharStream & generated classes
2020-01-24 16:31:38 +01:00
Andreas Dangel
5feca7fd93 Exclude generated AST*.java files from internalization 2020-01-24 16:19:24 +01:00
Andreas Dangel
35bb524803 [apex][java] *MetricsProvider are @InternalApi
Refs #2241
2020-01-24 15:56:04 +01:00
Clément Fournier
60e97d0ec8 Deprecate javacc generated code 2020-01-22 17:19:29 +01:00
Clément Fournier
08544a7539 Throw on metric not supported 2020-01-20 21:54:53 +01:00
Clément Fournier
055ae4abf0 Checkstyle 2020-01-20 00:57:45 +01:00
Clément Fournier
f576bc561a checkstyle 2020-01-19 16:13:02 +01:00
Clément Fournier
f87fc16ed3 Fix tests
The tests were wrong, so this changeset
actually fixes a bug in metrics
2020-01-19 15:10:30 +01:00
Clément Fournier
31497715e7 Merge branch 'node-api' 2020-01-19 13:05:32 +01:00
Clément Fournier
b707e6e9ff Fix caching
Non supported nodes produce NaN which is
converted to zero when converting to int
2020-01-19 13:04:22 +01:00
Clément Fournier
f282a3ad5c Move metric providers back into language handlers
Reverts part of #2231
2020-01-19 12:47:47 +01:00
Clément Fournier
2123ab3d5d Simplify metrics framework 2020-01-19 12:35:55 +01:00
Clément Fournier
27d7a6c02c Accomodate children iterable for specialization 2020-01-19 05:57:39 +01:00
Clément Fournier
436409e707 Merge branch 'issue-1984' 2020-01-17 18:32:16 +01:00
Andreas Dangel
fa85b4786d [core] Add Node#findDescendantsOfType with crossFindBoundaries that
returns a list like all other find-methods
2020-01-17 18:29:41 +01:00
Clément Fournier
19d35ff9e2 Don't use ClassNotFoundException to report unresolved classes
This speeds up type resolution by a factor of 2.
2020-01-17 18:01:55 +01:00
Andreas Dangel
0e2b9cf5b4 [java][apex] Move *MetricsProvider into own classes into metrics packages
Make *Metrics.reset package private again
2020-01-17 15:41:54 +01:00