1435 Commits

Author SHA1 Message Date
Clément Fournier
400ca5dca5 Delete test for findChildNodesWithXPath 2020-04-18 17:42:56 +02:00
Clément Fournier
e9cc7e00ef Merge branch 'master' into xpath-warnings 2020-04-18 17:36:44 +02:00
Andreas Dangel
c62041e827 Merge branch 'pr-2377'
[all] Update all XPath rules to XPath 2.0 #2377
2020-04-18 11:49:44 +02:00
Clément Fournier
4db656a679 Cleanup 2020-04-18 01:58:02 +02:00
Harsh Kukreja
9c98508fec Operator Wrap Issue Solved 2020-04-18 05:21:35 +05:30
Clément Fournier
be19da5a07 Test in pmd-core 2020-04-17 20:53:19 +02:00
Clément Fournier
f3db39641a Test with ASTVariableDeclaratorId#getName 2020-04-17 20:28:00 +02:00
Clément Fournier
be152e92a8 Output replacement as well 2020-04-17 20:18:32 +02:00
Clément Fournier
9dca569cc4 Make deprecation warnings for xpath rules mention the name of the rule
Fix #2019
2020-04-17 20:04:27 +02:00
Clément Fournier
48294ae668 Cleanup 2020-04-17 20:03:39 +02:00
Clément Fournier
798cce1666 Dont use global tree cache 2020-04-17 19:59:42 +02:00
Clément Fournier
7a37be55db Revert "don't use global namepool to avoid resource contention"
Actually benchmarking with different levels of
parallelism shows that there is no contention,
and that sharing the namepool is beneficial even
with many threads. When the number of threads is
very high, using independent namepools increases
the amount of work to allocate names.

This reverts commit 2253f38ccb999430b70b4b14c47cd6eb2b1758f7.
2020-04-17 18:03:57 +02:00
Clément Fournier
2253f38ccb don't use global namepool to avoid resource contention 2020-04-17 17:10:16 +02:00
Clément Fournier
9629cacddd Checstyle 2020-04-17 16:30:37 +02:00
Clément Fournier
dde5b29da8 Optimise attribute fetch
Use a map to fetch the
attribute, also don't recreate
attribute nodes so much, so that
the cache behind Method::invoke
in Attribute amounts to something.
2020-04-17 04:57:45 +02:00
Clément Fournier
12e843cb47 Pool names, optimize getNodeKind
NameTest::matches is a very hot spot
in saxon. Profiling shows that most
of its runtime is spent doing virtual
method dispatch on NodeInfo#getNodeKind

We optimise this by making a base class
with the node kind as a field.

Also, we now pool xpath names using saxon's
name pool, which reduces name tests to
integer comparison instead of string.equals

Saxon now spends 80x less time in the name test
overall shaving off 30% of execution time of
XPath rules.
2020-04-17 04:57:08 +02:00
Andreas Dangel
08d31c62a9 Merge branch 'master' into pr-2377 2020-04-16 17:52:03 +02:00
Andreas Dangel
ac21dc95b1 Merge branch 'pr-2407'
[core] Deprecate Jaxen and XPath internal API #2407
2020-04-13 12:17:58 +02:00
Andreas Dangel
5c31d40ec2 [core] XPathRule: use == for enum comparison 2020-04-13 12:16:55 +02:00
Andreas Dangel
85924b5ad1 Merge branch 'pr-2388'
[lang-test] Use tree dumps for regression tests #2388
2020-04-11 15:09:42 +02:00
Andreas Dangel
0710877d05 [core] Deprecate AntlrToken#getType() in favor of #getKind()
Refs #2371
2020-04-10 18:50:58 +02:00
Clément Fournier
60d443963c Call default ctor
Defines properties
2020-04-09 15:28:20 +02:00
Clément Fournier
60087590e6 Remove changes to XPathHandler 2020-04-08 22:07:26 +02:00
Clément Fournier
1de1d1c66d Update some usages early 2020-04-08 22:00:36 +02:00
Clément Fournier
5067c79eb2 Cleanup a test 2020-04-08 21:38:10 +02:00
Clément Fournier
8284fc8e81 Deprecate two other things 2020-04-08 21:35:34 +02:00
Clément Fournier
bcf90ceb8a Externalize creator for XPath rule 2020-04-08 21:35:34 +02:00
Clément Fournier
fc304bf70c Add XPath version maker 2020-04-08 21:35:34 +02:00
Andreas Dangel
69ed0464a7 Merge branch 'pr-2385'
[java] Make yield statements more conditional #2385

Fixes #2319
2020-04-04 18:20:49 +02:00
Andreas Dangel
5ed8570703 Add new rule: apex/bestpractices.xml/UnusedLocalVariable 2020-04-04 18:09:44 +02:00
Andreas Dangel
2f33951f60 Add new rules ruleset for release 6.23.0 2020-04-04 17:49:09 +02:00
Andreas Dangel
3e932de647 Merge branch 'master' into pr-2377 2020-04-03 16:25:22 +02:00
Andreas Dangel
b84e4dba88 Merge branch 'pr-2372'
[core] Deprecations for token managers #2372
2020-04-03 15:19:52 +02:00
Clément Fournier
e89c54fcf9 Cleanup 2020-03-28 18:01:32 +01:00
Clément Fournier
09ddc628cd Fix reference files 2020-03-28 17:46:33 +01:00
Clément Fournier
c83790fab5 Recycle tree printer from the designer 2020-03-28 17:46:33 +01:00
Clément Fournier
01c2389f58 Merge branch 'master' into xpath-update-rules 2020-03-28 17:32:22 +01:00
Clément Fournier
b01d4dc0d7 Test 2020-03-28 11:36:42 +01:00
Andreas Dangel
263c6e0d09 [core] Apply PR review suggestions, refs #2382 2020-03-27 17:46:07 +01:00
Andreas Dangel
8ffe160f12 [core] saxon rulechain: consider boolean expr 2020-03-27 13:35:51 +01:00
Andreas Dangel
a0e1e40bcb [core] saxon rulechain: don't use rule chain for other path expressions 2020-03-27 12:58:38 +01:00
Clément Fournier
3d429019ee Fix rules 2020-03-20 18:47:40 +01:00
Clément Fournier
0d65c2e6e6 Add relevant property tag 2020-03-20 18:47:40 +01:00
Clément Fournier
eaceefc39e Update XPath rules to 2.0 2020-03-20 18:47:40 +01:00
Clément Fournier
30886544c5 Deprecations to clean up CPD 2020-03-20 18:00:16 +01:00
Clément Fournier
3269b48add Merge branch 'saxon-rulechain' 2020-03-20 14:47:31 +01:00
Andreas Dangel
c0b70bdbc7 [core] Rename DesignerBindings.AdditionalInfo::getSortKey 2020-03-20 12:14:34 +01:00
Clément Fournier
a899a25350 Fix expr normalization when ids are negative 2020-03-19 19:29:13 +01:00
Clément Fournier
514a524e6f Checkstyle 2020-03-19 19:22:35 +01:00
Clément Fournier
20a3c39b4d Make SplitUnions package private 2020-03-19 19:11:30 +01:00