phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
18,445 Commits 16 Branches 123 Tags 510 MiB
Commit Graph

18445 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andreas Dangel
6041bb1ff6 Add @johnra2 as a contributor 2021-11-18 18:22:27 +01:00
Andreas Dangel
1393e7d830 [java] UselessStringValueOf - skip String.valueOf with more than one arg 2021-11-18 17:48:44 +01:00
John Armgardt
668136cfbc Created fix for UselessStringValueOf false positive 2021-11-11 19:15:21 -06:00
Andreas Dangel
f18ceebd7b Bump pmd from 6.39.0 to 6.40.0 2021-10-30 10:56:51 +02:00
Andreas Dangel
442365b975 Bump maven from 3.8.2 to 3.8.3 2021-10-30 10:56:19 +02:00
Andreas Dangel
51340b5df1 Prepare next development version 2021-10-30 10:17:33 +02:00
Andreas Dangel
f12710071f [maven-release-plugin] prepare for next development iteration 2021-10-30 10:00:20 +02:00
Andreas Dangel
be09a31654 [maven-release-plugin] prepare release pmd_releases/6.40.0 pmd_releases/6.40.0 2021-10-30 10:00:15 +02:00
Andreas Dangel
fd391160b4 Prepare pmd release 6.40.0 2021-10-30 09:45:25 +02:00
Andreas Dangel
d914447266 [ci] Improve stats script to consider closed milestones as well 2021-10-30 09:37:16 +02:00
Andreas Dangel
426865e20d [doc] release notes: add experimental api, fix missing closing tag 2021-10-30 09:29:08 +02:00
Andreas Dangel
ac26d3dc6d Merge pull request #3584 from adangel:issue-3563-classnamingconventions 
[java] ClassNamingConventions: Disable utilityClassPattern by default
#3584
 2021-10-29 19:16:58 +02:00
Andreas Dangel
857894928a Merge pull request #3557 from adangel:doc-vf-typeres 
[doc] Visualforce type resolution #3557

* pr-3557:
  [doc] Visualforce type resolution
 2021-10-29 19:15:28 +02:00
Andreas Dangel
9a07b81612 Merge pull request #3544 from adangel:issue-3368-hardcoded-crypto-key 
[java] HardcodedCryptoKey false negative with variable assignments #3368

* pr-3544:
  Simplify getUsages call
  Fix stack overflow error
  [java] HardcodedCryptoKey false negative with variable assignments
#3368
 2021-10-29 19:14:31 +02:00
Andreas Dangel
ec164b4bf0 Simplify getUsages call 
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
 2021-10-29 19:12:17 +02:00
Andreas Dangel
15270c8bd9 Merge pull request #3543 from adangel:issue-3542-missing-override-enum 
[java] MissingOverride: False negative for enum method #3542
 2021-10-29 19:07:49 +02:00
Andreas Dangel
f5fd79d489 Merge pull request #3582 from oowekyala:cleanup-3581 
[apex] Cleanup after #3581 #3582

* pr-3582:
  [apex] comments: use index instead of line/column to map to node
  [apex] comments: consider position index in the same line
  [apex] EmptyCatchBlock: Improve test case
  Added a new test case verifying the expected boundary condition behavior for allowing commented blocks.
  Cleanup after #3581
 2021-10-29 09:50:17 +02:00
Andreas Dangel
a9221d411b Merge pull request #3555 from adangel:update-apex-jorje 
[apex] Update jorje to version 54.0 (Spring '22) #3555

* pr-3555:
  [apex] Fix errors due to jorje update
  [apex] Update jorje to version 54.0 (Spring '22)
 2021-10-28 11:39:39 +02:00
Andreas Dangel
2a8db8b97c Merge branch 'master' into pr-3555 2021-10-28 11:35:12 +02:00
Andreas Dangel
b70b981145 [apex] comments: use index instead of line/column to map to node 2021-10-28 11:21:12 +02:00
Andreas Dangel
e05e0df39a [apex] comments: consider position index in the same line 2021-10-28 11:07:39 +02:00
Andreas Dangel
f3c17a0e02 [apex] EmptyCatchBlock: Improve test case 
also test for doc comments
 2021-10-28 10:29:08 +02:00
Scott Wells
aa271e5bc3 Added a new test case verifying the expected boundary condition behavior for allowing commented blocks. 2021-10-28 09:22:44 +02:00
Andreas Dangel
f4d34f96c4 [doc] Update release notes (#3574, #3580, #3581) 2021-10-25 19:18:40 +02:00
Andreas Dangel
3093013ff7 [java] ClassNamingConventions: Disable utilityClassPattern by default 
- Fixes #1595
- Fixes #3563
 2021-10-25 18:37:08 +02:00
Clément Fournier
7a9d0db3a7 Cleanup after #3581 2021-10-24 17:11:57 +02:00
Robert Sösemann
591d6c64ad Merge pull request #3581 from SCWells72/pmd-3569-feedback 2021-10-23 21:08:37 +02:00
Scott Wells
e0cd2a6ae2 Made the check for whether a node contains comments more efficient. Instead of having to inspect all commented lines in the file for each comment container, we now pre-calculate an index of which lines were comments, and then we see whether any of the lines in a comment container's range are flagged in that index. Given that we're currently only going to perform this logic for ASTCatchBlockStatement nodes, hopefully this should be very efficient. If/when this logic is expanded to include other node types, we can revisit and determine whether another approach such as a binary search for lines in a given range is a better fit. 
Made AbstractApexCommentContainerNode package-private.
 2021-10-23 13:58:34 -05:00
Robert Sösemann
515a6d0fd7 Merge pull request #3574 from SCWells72/pmd-3569 
[apex] Fix for #3569 - Added new configuration properties allowCommentedBlocks and allowExceptionNameRegex to EmptyCatchBlock
 2021-10-23 20:16:08 +02:00
Robert Sösemann
494520bb03 Merge pull request #3580 from SCWells72/pmd-3569-release-notes 
[doc] Release notes updates for the changes in issue #3569.
 2021-10-23 20:15:53 +02:00
Scott Wells
67c4f0bcb5 Addressed code review feedback, specifically providing tighter encapsulation for 'setContainsComment' and marking the 'ASTCommentContainer' interface as experimental. 2021-10-23 09:58:02 -05:00
Scott Wells
d8dbea8809 Release notes updates for the changes in issue 3569. 2021-10-23 09:14:25 -05:00
Scott Wells
a692f81611 Merge branch 'master' into pmd-3569 2021-10-23 08:46:06 -05:00
Andreas Dangel
fb731c257e [doc] Update release notes (#3570, #3575) 2021-10-23 11:34:04 +02:00
Andreas Dangel
38d60e2313 [doc] Update release notes (#3568, #3573) 2021-10-23 11:29:42 +02:00
Andreas Dangel
93c022505f [doc] Update release notes (#3578) 2021-10-23 11:26:33 +02:00
Andreas Dangel
1b5408d49a [apex] Update test, see #2775 / #3577 2021-10-23 11:21:32 +02:00
Andreas Dangel
3ef0360d65 [doc] Update release notes (#1090, #3576, #3577, #3579) 2021-10-23 11:17:10 +02:00
Andreas Dangel
8c7b0fbe9c [doc] Update release notes (#3566, #3572) 2021-10-23 10:45:10 +02:00
Andreas Dangel
8d2af36fbb Update @SCWells72 as a contributor 2021-10-23 10:41:43 +02:00
Andreas Dangel
2cb76f8b25 [doc] Update release notes (#1089, #3571) 2021-10-23 10:41:17 +02:00
Andreas Dangel
8ae662c90d [doc] Update doc about merging pull requests 
This includes now all-contributors and provides
standard merge commit messages.
 2021-10-23 10:35:37 +02:00
Robert Sösemann
f543babca6 Merge pull request #3575 from SCWells72/pmd-3570 
[apex] Fix for #3570 - Added new configuration property reportInForLoopInitializer to OneDeclarationPerLine
 2021-10-23 00:41:36 +02:00
Robert Sösemann
142b857750 Merge pull request #3573 from SCWells72/pmd-3568 
[apex] Fix for #3568 - Added new configuration properties reportEmptyPrivateNoArgConstructor and reportEmptyVirtualMethod to EmptyStatementBlock
 2021-10-23 00:38:38 +02:00
Robert Sösemann
0bc53fca8d Merge pull request #3578 from SCWells72/pmd-3576 
[apex] Documentation changes for #3576
 2021-10-23 00:36:27 +02:00
Scott Wells
914614f6a2 Merge branch 'master' into pmd-3569 2021-10-22 13:44:43 -05:00
Scott Wells
98b6479ecb Updated the rule documentation for the new config params. 2021-10-22 13:31:05 -05:00
Scott Wells
04096bbf01 Issue 3569 - Based on great feedback from Clément Fournier, decided to go a different route and add the exact same configuration properties that the analogous Java rule offers, specifically 'allowCommentedBlocks' and 'allowExceptionNameRegex', both with the exact same defaults as the Java rule, i.e., 'false' and '(expected|ignored)' respectively. 
Adding 'allowExceptionNameRegex' was quite straightforward. However, 'allowCommentedBlocks' was a bit more challenging because there was no notion of whether a block contained comments. I had to augment the lexer/parser/tree builder logic to capture all comment tokens and then use them to denote whether a catch block contained comments of any sort. The way I did this with a new intermediate abstract base node class for comment containers, we could denote the same for the other Apex block node types. In the spirit of keeping these changes narrow in scope, though, I only changed the inheritance hierarchy for ASTCatchBlockStatement. If/when we need to be able to ask the same question about other block types, it should be trivial to update them to support it.

Test cases have been updated accordingly.
 2021-10-22 13:01:19 -05:00
Robert Sösemann
b9f53ef56a Merge pull request #3577 from SCWells72/pmd-3576 2021-10-22 19:38:42 +02:00
Robert Sösemann
e67f2a0400 Merge pull request #3572 from SCWells72/pmd-3566 2021-10-22 19:09:50 +02:00