Andreas Dangel
773f792dd6
[java] Fix #5162 SingularField FP with synchronized block ( #5178 )
...
Merge pull request #5178 from oowekyala:issue5162-singularfield-synchronized
2024-08-29 13:05:50 +02:00
Andreas Dangel
610f937bc4
[java] Update AvoidSynchronizedAtMethodLevel message to mention ReentrantLock, new rule AvoidSynchronizedStatement ( #5175 )
...
Merge pull request #5175 from chonton:ReentrantLock
2024-08-29 12:50:13 +02:00
Andreas Dangel
3c3be3c81d
[doc] Update release notes ( #5175 )
2024-08-29 12:48:14 +02:00
Andreas Dangel
93db59bea5
Apply suggestions from code review
2024-08-29 12:41:02 +02:00
Juan Martín Sotuyo Dodero
91bb6f0b34
Improve docs further
2024-08-24 23:44:22 -03:00
Clément Fournier
d6736903f0
Fix #5162 SingularField FP with synchronized block
2024-08-25 00:46:45 +02:00
Juan Martín Sotuyo Dodero
45618c0e13
Merge branch 'master' into issue-5151
2024-08-24 18:20:38 -03:00
Clément Fournier
da864aeccd
Fix #5167 - issue with type projection
2024-08-24 16:48:37 +02:00
Juan Martín Sotuyo Dodero
c9c0558e2b
Suppress PMD warning
...
- "Simplifying" the return here would simply make it harder to read
2024-08-24 01:02:06 -03:00
Juan Martín Sotuyo Dodero
980eaacd13
Unify compile-time constant detection
...
- Improving the constant folder allows other rules to work better
- Fixes #3602
- Curiously, InefficientStringBuffering has been broken since PMD 7.0.0
(regression introduced in #3113 )
2024-08-24 00:48:53 -03:00
Juan Martín Sotuyo Dodero
8ecc21c06f
Merge branch 'master' into issue-5151
2024-08-24 00:14:55 -03:00
Juan Martín Sotuyo Dodero
96f60e9b0e
Handle computed array access keys
...
- Tidy up the code, the fact the `getLogLevelName` was cheating and
returning null when it considered a log to be safe was making the
code harder to think about
2024-08-24 00:11:43 -03:00
Clément Fournier
43112078a5
Fix issue #5145 - problem with inference of conditional exprs
...
Also finally fixes the bug that we swept under the rug in 24c1093b.
2024-08-23 18:23:43 +02:00
Charles Honton
8a39917fa2
added unit test
2024-08-22 13:54:17 -07:00
Charles Honton
3dd47a3b94
update AvoidSynchronizedAtMethodLevel message to mention ReentrantLock
...
see https://openjdk.org/jeps/8337395
2024-08-22 08:20:06 -07:00
Juan Martín Sotuyo Dodero
4033315c7d
Properly handle all qualifiable expressions
...
- Up date the documentation to better show what is being flagged
2024-08-21 23:40:04 -03:00
Juan Martín Sotuyo Dodero
90ebac893f
Fix whitespace
2024-08-19 01:45:37 -03:00
Juan Martín Sotuyo Dodero
9ef927067e
Fix tests regarding array accesses
2024-08-18 19:41:06 -03:00
Juan Martín Sotuyo Dodero
4352b53aec
Add tests regarding array accesses
2024-08-18 19:40:51 -03:00
Juan Martín Sotuyo Dodero
abcc20e655
Fix #5152
2024-08-18 19:29:48 -03:00
Juan Martín Sotuyo Dodero
176fae39d2
Add test for #5152
2024-08-18 19:29:39 -03:00
Juan Martín Sotuyo Dodero
792d91e062
Fix GuardLogStatementRule for field accesses
2024-08-18 19:23:25 -03:00
Juan Martín Sotuyo Dodero
ca34c3edd3
Add minimal failing case for #5151
2024-08-18 19:22:09 -03:00
Andreas Dangel
ee800d326f
[release] Prepare next development version [skip ci]
2024-07-26 10:11:46 +02:00
Andreas Dangel
db5fa2dbce
[release] prepare release pmd_releases/7.4.0
2024-07-26 09:03:38 +02:00
Andreas Dangel
41393d4637
[java] AccessorClassGeneration - handle default ctors
...
Fixes #5106
2024-07-25 13:05:47 +02:00
Andreas Dangel
a3f9d4af59
[java] Simplify UnusedPrivateMethodRule
...
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
2024-07-25 09:57:20 +02:00
Andreas Dangel
1464cbca38
[java] Fix UnusedPrivateMethod for @lombok.Builder.ObtainVia ( #5111 )
...
Merge pull request #5111 from kdebski85:issue-5110-lombok-obtain-via
2024-07-23 20:11:23 +02:00
Andreas Dangel
e8bfc0d01c
[java] UnusedPrivateMethodRule - fixups from PR review
2024-07-23 20:05:11 +02:00
Krzysztof Debski
57e8954556
[java] Simplify processing of MethodSource annotation
2024-07-22 17:33:45 +02:00
Krzysztof Debski
121cdba3a4
[java] Make 'ASTAnnotation#flatValue' method static
2024-07-22 13:27:04 +02:00
Krzysztof Debski
9006dd1a89
[java] Generalize annotation handling in UnusedPrivateMethodRule
2024-07-22 13:22:24 +02:00
Andreas Dangel
4d2034ef0f
[java] FP for UnusedPrivateMethod with Jakarta @PostConstruct/PreDestroy annotations ( #5118 )
...
Merge pull request #5118 from kdebski85:issue-5117-unused-private-method-jakarta
2024-07-19 14:48:03 +02:00
Krzysztof Debski
cb1d1963a4
[java] Ignore unused private methods referenced by any field annotation attribute
2024-07-17 10:18:31 +02:00
Krzysztof Debski
9d0719201d
[java] Do not report UnusedPrivateMethod for method annotated with @jakarta.annotation.PostConstruct/PreDestroy
2024-07-15 16:31:58 +02:00
Krzysztof Debski
45d68cf455
[java] Imports order fix
2024-07-11 17:33:39 +02:00
Krzysztof Debski
3609034bf7
[java] Do not report MissingStaticMethodInNonInstantiatableClass for class with @lombok.Builder
2024-07-11 17:24:38 +02:00
Krzysztof Debski
c053f00fb5
[java] Do not report UnusedPrivateMethod for method referenced by @lombok.Builder.ObtainVia
2024-07-11 17:00:01 +02:00
Krzysztof Debski
3a66d50ac2
[java] Do not report MissingStaticMethodInNonInstantiatableClass for private constructor with @lombok.Builder
2024-07-11 15:30:01 +02:00
Andreas Dangel
fc128c18dd
[java] Fix example of JUnitStaticSuite
...
A method can be declared only once, so
split the example into two examples.
2024-07-05 09:16:42 +02:00
Andreas Dangel
d952a10790
[release] Prepare next development version [skip ci]
2024-06-28 11:27:41 +02:00
Andreas Dangel
c5dbc29bea
[release] prepare release pmd_releases/7.3.0
2024-06-28 11:00:04 +02:00
Andreas Dangel
06ba547811
[java] Make impl of ASTLiteral#getLiteralText() public ( #5078 )
...
Merge pull request #5078 from adangel:issue-4885-method-should-be-accessible
2024-06-27 14:49:13 +02:00
Andreas Dangel
fbc5ddb103
[java] Add new rule UseEnumCollections ( #5038 )
...
Merge pull request #5038 from oowekyala:issue577-new-rule-use-enum-collections
2024-06-27 14:07:31 +02:00
Andreas Dangel
bc0b2c9763
Merge branch 'master' into pr-5038
2024-06-27 11:41:13 +02:00
Andreas Dangel
bf8e11d9b4
[doc] Update release notes ( #577 , #5038 )
2024-06-27 11:40:18 +02:00
Andreas Dangel
f37d432b9e
Revert "support TreeSet/Map"
...
This reverts commit 209fc134621862b7043dd05ac72265cd21a838d2.
2024-06-27 11:29:00 +02:00
Andreas Dangel
c2a7c46ccd
Merge branch 'master' into pr-5051
2024-06-27 11:00:56 +02:00
Andreas Dangel
69d2d7de28
[java] Rebuild SomeRecordsTestData.java
2024-06-27 10:55:55 +02:00
Andreas Dangel
31b4e3745a
[doc] Update release notes ( #5050 , #5051 )
2024-06-27 10:49:20 +02:00
