Commit Graph
2844 Commits
Author SHA1 Message Date
Andreas Dangel 90903f076b [java] Document deprecations in code for PositionLiterals*Rule 2020-05-22 19:48:46 +02:00
John Teng 261f2d747a removed unintentional keypress 2020-05-18 16:58:13 -04:00
John Teng 01c283ce00 Added deprecated tags to code and bestpractices ruleset, updated quickstart ruleset 2020-05-18 16:56:12 -04:00
Andreas Dangel 0cc00277d3 Merge branch 'pr-2474'
[core] Stop JavaCharStream from throwing Error #2474
2020-05-18 20:28:37 +02:00
Andreas Dangel 3449c9a372 Merge branch 'pr-2478'
[java] New rule: LiteralsFirstInComparisons #2478
2020-05-18 20:17:23 +02:00
Andreas Dangel 526526be47 [java] Reformat (whitespaces) LiteralsFirstInComparisons.xml 2020-05-18 20:16:41 +02:00
Andreas Dangel 7138d2e4d4 [doc] Update release notes, refs #2478 2020-05-18 20:11:45 +02:00
Andreas Dangel 0fa0c4a70c [java] add new rule in quickstart.xml 2020-05-18 20:11:04 +02:00
Andreas Dangel 979d81c02e Merge branch 'pr-2481'
[java] Fix JUnitSpellingRule false positive #2481
2020-05-18 19:57:45 +02:00
Andreas Dangel dfd5e608d6 [java] Remove unnecessary CDATA in JUnitSpelling.xml 2020-05-18 19:55:39 +02:00
Artem Krosheninnikov ad68cdda24 Fix review remarks 2020-05-16 23:26:24 +03:00
Clément Fournier 382a1a15f6 Merge branch 'improve-alias-api' 2020-05-16 19:22:10 +02:00
John Teng 72128e1476 fixed the rule version, removed CDATA tags from descriptions 2020-05-15 10:43:51 -04:00
Juan Martín Sotuyo Dodero 0f552ee620 Further refine the addVersion API 2020-05-15 11:42:28 -03:00
Juan Martín Sotuyo Dodero 8c7a49eb69 [core] Revamp the language version alias APIs
- The old experimental API allowed calls such as
`addVersions(langHandler, false)` which were not only invalid, but would
throw an `ArrayIndexOutOfBoundsException`, so we split the name
(required) and the aliases (varargs, and therefore optional)
 - In doing so, I was bothered by parameter order. The version name is
the most significant change when setting 2 versions for a language, so I
liked it being first as the old `addVersion` method did, so I moved
that ahead.
 - With that, I now had 2 methods that where equivalent, except one
allowed for varargs and the other didn't… so I merged them. This is not
100% binary compatible, but it is source compatible (that is, unless you
used reflection, all valid calls to the old non-experimental method
still work).
2020-05-14 16:03:45 -03:00
Andreas Dangel 8fce3a300f [java] Small refactoring for JUnitTestsShouldIncludeAssertRule 2020-05-14 20:30:24 +02:00
Artem Krosheninnikov 8b5be784fd fix pmd violation 2020-05-13 02:05:27 +03:00
Artem Krosheninnikov d349d66696 fix JUnitSpellingRule false positive, closes #2477. Also add two more tests 2020-05-13 01:46:36 +03:00
andreoss 1f0d7ae620 [java] False positive with Hamcrest's assertThat
Fixes #2288
2020-05-12 17:51:54 -04:00
John Teng 99db8b4373 Added new rule to bestpractices category, added unit tests for all comparison cases 2020-05-12 17:07:21 -04:00
John Teng 8ff452080b Added new rule corresponding to all string literal comparisons 2020-05-12 17:06:08 -04:00
Clément Fournier bf027382f5 Test 2020-05-07 18:14:42 +02:00
Clément Fournier 0adb7c8635 Add some DeprecatedAttribute annotations
This improves warnings for XPath rules
2020-04-28 08:23:27 +02:00
Harsh Kukreja b2dc358aba Operator Wrap check 2020-04-27 09:09:07 +05:30
Andreas Dangel 4308c545e5 [maven-release-plugin] prepare for next development iteration 2020-04-24 10:53:12 +02:00
Andreas Dangel 921c65f5ab [maven-release-plugin] prepare release pmd_releases/6.23.0 2020-04-24 10:53:00 +02:00
Andreas Dangel aee04b4c68 [java] Fix more deprecated attribute usages 2020-04-18 19:06:29 +02:00
Andreas Dangel bcae7e5243 Small corrections 2020-04-18 18:20:27 +02:00
Clément Fournier e2ec5450ff Update rules
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/AvoidEnumAsIdentifier, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/AvoidAssertAsIdentifier, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/ProperLogger, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/JumbledIncrementer, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/AvoidLosingExceptionInformation, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/EmptyCatchBlock, please use @Name instead
2020-04-17 20:34:42 +02:00
Clément Fournier f3db39641a Test with ASTVariableDeclaratorId#getName 2020-04-17 20:28:00 +02:00
Clément Fournier be152e92a8 Output replacement as well 2020-04-17 20:18:32 +02:00
Andreas Dangel de875c955a [java] Convert JUnitStaticSuite to Java rule 2020-04-17 15:21:58 +02:00
Andreas Dangel c8bdc4fade [java] UseCorrectExceptionLogging - fix problem with multiple loggers 2020-04-17 14:53:26 +02:00
Andreas Dangel 80a40c00ef [java] Convert AbstractClassWithoutAbstractMethod to Java rule 2020-04-17 12:01:27 +02:00
Andreas Dangel 797a965c4b [java] Convert JUnitSpelling to Java rule 2020-04-17 11:51:06 +02:00
Andreas Dangel e81fee9ee5 [java] Convert PositionLiteralsFirstIn*Comparisons to Java rules 2020-04-17 11:24:23 +02:00
Andreas Dangel 319fe80d85 [java] Simplify AvoidDecimalLiteralsInBigDecimalConstructor with type res 2020-04-16 18:57:36 +02:00
Andreas Dangel feee0b8f91 [java] Replace XPath ProperCloneImplementation with Java Rule 2020-04-16 18:57:10 +02:00
Andreas Dangel 08d31c62a9 Merge branch 'master' into pr-2377 2020-04-16 17:52:03 +02:00
Clément Fournier ea532e6d2d Rename RecordDeclaration::getComponentList to getRecordComponents
This name is clearer when seen from the
interface ASTAnyTypeDeclaration, also
it matches the Class API
2020-04-16 14:28:59 +02:00
Andreas Dangel ac21dc95b1 Merge branch 'pr-2407'
[core] Deprecate Jaxen and XPath internal API #2407
2020-04-13 12:17:58 +02:00
Andreas Dangel 0726496726 Merge branch 'pr-2409'
[java] ClassNamingConventions suggests to add Util for class containing only static constants, fixes #1164 #2409
2020-04-13 12:06:01 +02:00
BlightbusterandGitHub 8c2edd625f Fix UseAssertEqualsInsteadOfAssertTrue Example
String used ? instead of "
2020-04-11 14:32:43 +02:00
Binu R J f4b95a3ae3 [java] ClassNamingConventions suggests to add Util for class containing only static constants, fixes #1164 2020-04-09 19:15:39 +05:30
Clément Fournier 60d443963c Call default ctor
Defines properties
2020-04-09 15:28:20 +02:00
Clément Fournier 5067c79eb2 Cleanup a test 2020-04-08 21:38:10 +02:00
Clément Fournier 961e78954a Update some tests 2020-04-08 21:35:34 +02:00
Andreas Dangel c7941638e8 Merge branch 'pr-2401'
[doc] Update DoNotUseThreads rule documentation #2401
2020-04-06 20:21:32 +02:00
Bernd Farka f28bdbed5e issue 2402 fix false-positives on Primitive Streams 2020-04-05 19:47:52 +02:00
Saikat dcde4258b3 Update DoNotUseThreads rule documentation
Fixes #2313 [java] Documentation for DoNotUseThreads is outdated
2020-04-05 11:46:51 +05:30